This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Provide a proper default location for llvm-lit for out-of-tree users on Windows host.
ClosedPublic

Authored by vvereschaka on Apr 29 2020, 4:31 PM.

Details

Summary

llvm-lit gets '.py' extension on Windows host during its configuration. We need to provide a correct name for llvm-lit including file extension within LLVM_CONFIG_DEFAULT_EXTERNAL_LIT variable.

Update for commit 45526d29a5b2cf126b83ada3991921970007d16f.

Diff Detail

Event Timeline

vvereschaka created this revision.Apr 29 2020, 4:31 PM

also we get the following cmake warning during the build

CMake Warning at C:/buildbot/as-builder-1/llvm-clang-win-x-armv7l/llvm-project/llvm/cmake/modules/AddLLVM.cmake:1638 (message):
  LLVM_EXTERNAL_LIT set to
  C:/buildbot/as-builder-1/llvm-clang-win-x-armv7l/build/./bin/llvm-lit, but
  the path does not exist.
Call Stack (most recent call first):
  C:/buildbot/as-builder-1/llvm-clang-win-x-armv7l/llvm-project/llvm/cmake/modules/AddLLVM.cmake:1682 (get_llvm_lit_path)
  C:/buildbot/as-builder-1/llvm-clang-win-x-armv7l/llvm-project/llvm/cmake/modules/AddLLVM.cmake:1727 (add_lit_target)
  C:/buildbot/as-builder-1/llvm-clang-win-x-armv7l/llvm-project/libunwind/test/CMakeLists.txt:33 (add_lit_testsuite)

(http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/7142/steps/build-llvm-project/logs/stdio)

LGTM. thanks!

This revision is now accepted and ready to land.Apr 29 2020, 7:51 PM
This revision was automatically updated to reflect the committed changes.