HomePhabricator

[DebugInfo] Update loop metadata in stripNonLineTableDebugInfo

Authored by vsk on Apr 30 2020, 1:22 PM.

Description

[DebugInfo] Update loop metadata in stripNonLineTableDebugInfo

Summary:
Have stripNonLineTableDebugInfo() attach updated !llvm.loop metadata to
an instruction (instead of updating and then discarding the metadata).

This fixes "!dbg attachment points at wrong subprogram for function"
errors seen while archiving an iOS app.

It would be nice -- as a follow-up -- to catch this issue earlier,
perhaps by modifying the verifier to constrain where DILocations are
allowed. Any alternative suggestions appreciated.

rdar://61982466

Reviewers: aprantl, dsanders

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D79200

Details

Committed
vskMay 1 2020, 11:36 AM
Differential Revision
D79200: [DebugInfo] Update loop metadata in stripNonLineTableDebugInfo
Parents
rGcd05707d08b1: [libc++] Try re-enabling DSL test on Windows
Branches
Unknown
Tags
Unknown