Page MenuHomePhabricator

[mlir][vector] let type_cast take non-zero addrspace.
ClosedPublic

Authored by whchung on Apr 29 2020, 9:23 AM.

Details

Summary

Enhance lowering logic and tests so vector.type_cast take memrefs on non-zero addrspaces.

Diff Detail

Event Timeline

whchung created this revision.Apr 29 2020, 9:23 AM
whchung edited the summary of this revision. (Show Details)Apr 29 2020, 9:24 AM
whchung updated this revision to Diff 261026.Apr 29 2020, 2:09 PM

Fix FileCheck macros to properly scan the symbol we are looking for.

ftynse accepted this revision.Apr 30 2020, 12:57 AM
This revision is now accepted and ready to land.Apr 30 2020, 12:57 AM
aartbik accepted this revision.Apr 30 2020, 1:23 PM

This patch no longer applies, could you please rebase?

@ftynse Just did a rebase and it turns out in the latest tip memory addrspace is already being considered. Hence I changed this patch to only include a unit test.

This revision was automatically updated to reflect the committed changes.