Paths

Table of Contentst

Differential D78803

[MLIR] Remove document references to gpu.kernel_module and gpu.kernel.
ClosedPublic
Actions

Authored by tpopp on Apr 24 2020, 3:35 AM.

Details

Reviewers

herhut
pifon2a
frgossen

Commits

rG49d8625aefb8: [MLIR] Remove document references to gpu.kernel_module and gpu.kernel.

Summary

These have been replaced from attributes to operations gpu.module and
gpu.func respectively.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	160 ms	MLIR.Dialect/Vector::Unknown Unit Message ("") Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/build/bin/mlir-opt /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/mlir/test/Dialect/Vector/vector-transforms.mlir -test-vector-to-vector-conversion \| /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/build/bin/FileCheck /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/mlir/test/Dialect/Vector/vector-transforms.mlir
	660 ms	MLIR.mlir-tblgen::Unknown Unit Message ("") Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/build/bin/mlir-opt -test-patterns -mlir-print-debuginfo /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/mlir/test/mlir-tblgen/pattern.mlir \| /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/build/bin/FileCheck /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/mlir/test/mlir-tblgen/pattern.mlir --dump-input-on-failure

Event Timeline

tpopp created this revision.Apr 24 2020, 3:35 AM

Herald added a project: Restricted Project. · View Herald TranscriptApr 24 2020, 3:35 AM

Herald added subscribers: llvm-commits, Kayjukh, grosul1 and 14 others. · View Herald Transcript

pifon2a accepted this revision.Apr 24 2020, 3:52 AM

This revision is now accepted and ready to land.Apr 24 2020, 3:52 AM

Harbormaster completed remote builds in B54564: Diff 259847.Apr 24 2020, 4:17 AM

Thank you.

mlir/include/mlir/Dialect/GPU/GPUOps.td
266	The kernel is now identified with a single nested symbol attribute `kernel` (https://github.com/llvm/llvm-project/commit/0372db05bb1552c2b39fc735f949977e0a863a25). I should have updated this, sorry.

This revision now requires changes to proceed.Apr 24 2020, 4:31 AM

Update comment on the kernel attribute of gpu.launch_func.

tpopp marked an inline comment as done.Apr 24 2020, 7:33 AM

frgossen accepted this revision.Apr 24 2020, 7:46 AM

This revision is now accepted and ready to land.Apr 24 2020, 7:46 AM

Harbormaster failed remote builds in B54572: Diff 259884!Apr 24 2020, 8:04 AM

Closed by commit rG49d8625aefb8: [MLIR] Remove document references to gpu.kernel_module and gpu.kernel. (authored by Tres Popp <tpopp@google.com>). · Explain WhyApr 27 2020, 1:01 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

mlir/

docs/

Dialects/

5 lines

include/

mlir/

Dialect/

GPU/

14 lines

Diff 259884

mlir/docs/Dialects/SPIR-V.md

Loading...

mlir/include/mlir/Dialect/GPU/GPUOps.td

Loading...