This is an archive of the discontinued LLVM Phabricator instance.

Differential D78703

[libc] Add spec for sigdelset and sigfillset.
ClosedPublic

Authored by PaulkaToast on Apr 23 2020, 4:50 AM.

Details

Reviewers
abrachet
sivachandra
Commits
rG29213878e7dc: [libc] Add spec for sigdelset and sigfillset.
Summary

Caught by libc-tidy from patch D77281.

Diff Detail

Unit TestsFailed

TimeTest
11,050 mslldb-api.commands/expression/import-std-module/basic::Unknown Unit Message ("")
3,430 mslldb-api.commands/expression/import-std-module/conflicts::Unknown Unit Message ("")
5,490 mslldb-api.commands/expression/import-std-module/deque-basic::Unknown Unit Message ("")
5,530 mslldb-api.commands/expression/import-std-module/deque-dbg-info-content::Unknown Unit Message ("")
5,090 mslldb-api.commands/expression/import-std-module/forward_list::Unknown Unit Message ("")
View Full Test Results (41 Failed)

Event Timeline

PaulkaToast created this revision.Apr 23 2020, 4:50 AM
Herald added subscribers: libc-commits, tschuett. · View Herald TranscriptApr 23 2020, 4:51 AM
Harbormaster failed remote builds in B54382: Diff 259525!Apr 23 2020, 6:27 AM
abrachet added a comment.Apr 23 2020, 9:50 AM

Oops, thanks for fixing this

Could we also add these in libc/lib/CMakeLists.txt which I also forgot?

libc/spec/posix.td
186

Oops, thanks for adding that!

192

sigfillset doesn't take a second int.

PaulkaToast updated this revision to Diff 259713.Apr 23 2020, 2:26 PM
PaulkaToast marked 3 inline comments as done.
PaulkaToast added inline comments.
libc/spec/posix.td
192

Oops!

PaulkaToast updated this revision to Diff 259723.Apr 23 2020, 3:06 PM
PaulkaToast marked an inline comment as done.

Add to lib CMakeLists.

Herald added a subscriber: mgorny. · View Herald TranscriptApr 23 2020, 3:06 PM
abrachet accepted this revision.Apr 23 2020, 3:48 PM

Thanks!

This revision is now accepted and ready to land.Apr 23 2020, 3:48 PM
Harbormaster failed remote builds in B54488: Diff 259713!Apr 23 2020, 4:20 PM
Closed by commit rG29213878e7dc: [libc] Add spec for sigdelset and sigfillset. (authored by PaulkaToast). · Explain WhyApr 23 2020, 4:54 PM
This revision was automatically updated to reflect the committed changes.
MaskRay added a subscriber: MaskRay.Apr 23 2020, 5:07 PM

You can delete unneeded Phabricator tags (Reviewers: Tags: Subscribers:) with:

arcfilter () {
        arc amend
        git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend -F -
}
Harbormaster failed remote builds in B54497: Diff 259723!Apr 23 2020, 5:25 PM

Revision Contents

PathSize
libc/
config/
linux/
2 lines
lib/
2 lines
spec/
12 lines

Diff 259723

libc/config/linux/api.td

Show First 20 Lines • Show All 264 Lines • ▼ Show 20 Linesdef SignalAPI : PublicAPI<"signal.h"> {
let TypeDeclarations = [ let TypeDeclarations = [
StructSigactionDefn, StructSigactionDefn,
SighandlerTDefn, SighandlerTDefn,
]; ];
let Functions = [ let Functions = [
"raise", "raise",
"sigaction", "sigaction",
"sigdelset",
"sigprocmask", "sigprocmask",
"sigemptyset", "sigemptyset",
"sigaddset", "sigaddset",
"sigfillset",
"signal", "signal",
]; ];
} }
def MtxT : TypeDecl<"mtx_t"> { def MtxT : TypeDecl<"mtx_t"> {
let Decl = [{ let Decl = [{
typedef struct { typedef struct {
unsigned char __internal_data[4]; unsigned char __internal_data[4];
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines

libc/lib/CMakeLists.txt

add_entrypoint_library( add_entrypoint_library(
llvmlibc llvmlibc
DEPENDS DEPENDS
# assert.h entrypoints # assert.h entrypoints
libc.src.assert.__assert_fail libc.src.assert.__assert_fail
# errno.h entrypoints # errno.h entrypoints
libc.src.errno.__errno_location libc.src.errno.__errno_location
# signal.h entrypoints # signal.h entrypoints
libc.src.signal.raise libc.src.signal.raise
libc.src.signal.sigaction libc.src.signal.sigaction
libc.src.signal.sigdelset
libc.src.signal.sigaddset libc.src.signal.sigaddset
libc.src.signal.sigemptyset libc.src.signal.sigemptyset
libc.src.signal.sigprocmask libc.src.signal.sigprocmask
libc.src.signal.sigfillset
libc.src.signal.signal libc.src.signal.signal
# stdlib.h entrypoints # stdlib.h entrypoints
libc.src.stdlib._Exit libc.src.stdlib._Exit
libc.src.stdlib.abort libc.src.stdlib.abort
# string.h entrypoints # string.h entrypoints
libc.src.string.memcpy libc.src.string.memcpy
Show All 33 Lines

libc/spec/posix.td

Show First 20 Lines • Show All 152 Lines • ▼ Show 20 Lines HeaderSpec Signal = HeaderSpec<
FunctionSpec< FunctionSpec<
"sigaction", "sigaction",
RetValSpec<IntType>, RetValSpec<IntType>,
[ArgSpec<IntType>, [ArgSpec<IntType>,
ArgSpec<ConstRestrictStructSigactionPtr>, ArgSpec<ConstRestrictStructSigactionPtr>,
ArgSpec<RestrictStructSigactionPtr>] ArgSpec<RestrictStructSigactionPtr>]
>, >,
FunctionSpec< FunctionSpec<
"sigdelset",
RetValSpec<IntType>,
[ArgSpec<SigSetPtrType>,
ArgSpec<IntType>]
>,
FunctionSpec<
"sigprocmask", "sigprocmask",
RetValSpec<IntType>, RetValSpec<IntType>,
[ArgSpec<IntType>, ArgSpec<ConstRestrictSigSetType>, ArgSpec<RestrictSigSetType>] [ArgSpec<IntType>, ArgSpec<ConstRestrictSigSetType>, ArgSpec<RestrictSigSetType>]
>, >,
FunctionSpec< FunctionSpec<
"sigemptyset", "sigemptyset",
RetValSpec<IntType>, RetValSpec<IntType>,
[ArgSpec<SigSetPtrType>] [ArgSpec<SigSetPtrType>]
>, >,
FunctionSpec< FunctionSpec<
"sigaddset", "sigaddset",
RetValSpec<IntType>, RetValSpec<IntType>,
[ArgSpec<SigSetPtrType>,
ArgSpec<IntType>]
>,
FunctionSpec<
"sigfillset",
RetValSpec<IntType>,
[ArgSpec<SigSetPtrType>] [ArgSpec<SigSetPtrType>]
>, >,
abrachetUnsubmitted
Done
ReplyInline Actions

Oops, thanks for adding that!

abrachet: Oops, thanks for adding that!
] ]
>; >;
HeaderSpec UniStd = HeaderSpec< HeaderSpec UniStd = HeaderSpec<
"unistd.h", "unistd.h",
[], // Macros [], // Macros
abrachetUnsubmitted
Done
ReplyInline Actions

sigfillset doesn't take a second int.

abrachet: `sigfillset` doesn't take a second int.
PaulkaToastAuthorUnsubmitted
Done
ReplyInline Actions

Oops!

PaulkaToast: Oops!
[ [
SSizeTType, SSizeTType,
SizeTType, SizeTType,
], ],
[], // Enumerations [], // Enumerations
[ [
FunctionSpec< FunctionSpec<
"write", "write",
Show All 13 Lines