Page MenuHomePhabricator

PaulkaToast (Paula Toth)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 5 2020, 11:18 PM (11 w, 5 d)

Recent Activity

Today

PaulkaToast updated the summary of D76978: [libc builder] Add custom step to run clang-tidy..
Sat, Mar 28, 1:35 AM · Restricted Project, Restricted Project
PaulkaToast created D76978: [libc builder] Add custom step to run clang-tidy..
Sat, Mar 28, 1:35 AM · Restricted Project, Restricted Project

Yesterday

PaulkaToast accepted D76967: [libc][NFC] Ensure internal implementation is in __llvm_libc namespace.

Can we just remove the namespace?

Fri, Mar 27, 11:05 PM · Restricted Project
PaulkaToast updated the diff for D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace..

Updated to handle nested namespaces, exclude C linkages functions, and made check language specific. (:

Fri, Mar 27, 5:05 PM · Restricted Project, Restricted Project
PaulkaToast added a comment to D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace..

If you want to make it a general check, you should consider making the default module options set the correct namespace
RequiredNamespace

Fri, Mar 27, 5:05 PM · Restricted Project, Restricted Project

Thu, Mar 26

PaulkaToast added a comment to D76825: [libc] Move implementations of cosf, sinf, sincosf to src/math directory..

Won't deleting the files in the AOR directory cause the make check on the buildbots to fail? It might make sense to leave the files and delete them once all functions have been migrated?

Thu, Mar 26, 9:12 PM · Restricted Project
PaulkaToast added inline comments to D76676: [libc] Unblock SIGABRT before raising in abort.
Thu, Mar 26, 5:57 PM

Wed, Mar 25

PaulkaToast added inline comments to D76744: [clang-tidy] Add check to ensure llvm-libc implementations are defined in correct namespace..
Wed, Mar 25, 6:58 PM · Restricted Project, Restricted Project
PaulkaToast abandoned D76744: [clang-tidy] Add check to ensure llvm-libc implementations are defined in correct namespace..

Abandoning for a more generalized check. D76818

Wed, Mar 25, 6:58 PM · Restricted Project, Restricted Project
PaulkaToast created D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace..
Wed, Mar 25, 6:25 PM · Restricted Project, Restricted Project

Tue, Mar 24

PaulkaToast added inline comments to D76723: [libc] Generate math.h instead of the static file it is currently..
Tue, Mar 24, 11:57 PM · Restricted Project
PaulkaToast created D76744: [clang-tidy] Add check to ensure llvm-libc implementations are defined in correct namespace..
Tue, Mar 24, 7:09 PM · Restricted Project, Restricted Project

Mon, Mar 23

PaulkaToast committed rGdab219eedd29: [libc] Enable llvmlibc clang-tidy checks (authored by PaulkaToast).
[libc] Enable llvmlibc clang-tidy checks
Mon, Mar 23, 8:42 PM
PaulkaToast closed D76559: [libc] Enable llvmlibc clang-tidy checks.
Mon, Mar 23, 8:41 PM · Restricted Project

Sat, Mar 21

PaulkaToast added inline comments to D76559: [libc] Enable llvmlibc clang-tidy checks.
Sat, Mar 21, 7:46 PM · Restricted Project
PaulkaToast updated the summary of D76559: [libc] Enable llvmlibc clang-tidy checks.
Sat, Mar 21, 6:10 PM · Restricted Project
PaulkaToast added reviewers for D76559: [libc] Enable llvmlibc clang-tidy checks: sivachandra, abrachet.
Sat, Mar 21, 6:10 PM · Restricted Project
PaulkaToast created D76559: [libc] Enable llvmlibc clang-tidy checks.
Sat, Mar 21, 6:10 PM · Restricted Project

Fri, Mar 20

PaulkaToast committed rZORGf333f4c0f1f4: [libc builder] Add custom step for AOR tests. (authored by PaulkaToast).
[libc builder] Add custom step for AOR tests.
Fri, Mar 20, 6:59 PM
PaulkaToast closed D76331: [libc builder] Add custom step for AOR tests..
Fri, Mar 20, 6:59 PM · Restricted Project, Restricted Project
PaulkaToast added inline comments to D76331: [libc builder] Add custom step for AOR tests..
Fri, Mar 20, 4:50 PM · Restricted Project, Restricted Project
PaulkaToast added a comment to D76393: Allow remapping the sysroot with -fdebug-prefix-map..

This seems to be causing a failure in our buildbot, mind taking a look? (:

Fri, Mar 20, 4:50 PM · Restricted Project, debug-info
PaulkaToast committed rG556b917fffcf: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers… (authored by PaulkaToast).
[clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers…
Fri, Mar 20, 4:18 PM
PaulkaToast closed D76395: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes.
Fri, Mar 20, 4:18 PM · Restricted Project, Restricted Project
PaulkaToast updated the diff for D76331: [libc builder] Add custom step for AOR tests..
Fri, Mar 20, 1:34 PM · Restricted Project, Restricted Project
PaulkaToast added inline comments to D76331: [libc builder] Add custom step for AOR tests..
Fri, Mar 20, 1:34 PM · Restricted Project, Restricted Project
PaulkaToast added a comment to D76395: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes.

Thanks!

Fri, Mar 20, 12:28 PM · Restricted Project, Restricted Project
PaulkaToast updated the diff for D76395: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes.
Fri, Mar 20, 12:28 PM · Restricted Project, Restricted Project
PaulkaToast updated the diff for D76331: [libc builder] Add custom step for AOR tests..
Fri, Mar 20, 4:18 AM · Restricted Project, Restricted Project
PaulkaToast updated the diff for D76331: [libc builder] Add custom step for AOR tests..
Fri, Mar 20, 4:18 AM · Restricted Project, Restricted Project

Wed, Mar 18

PaulkaToast updated the diff for D76395: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes.
Wed, Mar 18, 5:55 PM · Restricted Project, Restricted Project
PaulkaToast created D76395: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes.
Wed, Mar 18, 4:51 PM · Restricted Project, Restricted Project
PaulkaToast added inline comments to D76331: [libc builder] Add custom step for AOR tests..
Wed, Mar 18, 1:01 PM · Restricted Project, Restricted Project

Tue, Mar 17

PaulkaToast committed rGa9e05d5711a8: [libc] Add AOR testing dependencies for buildbot workers. (authored by PaulkaToast).
[libc] Add AOR testing dependencies for buildbot workers.
Tue, Mar 17, 5:51 PM
PaulkaToast closed D76330: [libc] Add AOR testing dependencies for buildbot workers..
Tue, Mar 17, 5:51 PM · Restricted Project
PaulkaToast updated the diff for D76331: [libc builder] Add custom step for AOR tests..

Addressed comments. (:

Tue, Mar 17, 5:51 PM · Restricted Project, Restricted Project
PaulkaToast updated the summary of D76331: [libc builder] Add custom step for AOR tests..
Tue, Mar 17, 3:07 PM · Restricted Project, Restricted Project
PaulkaToast created D76331: [libc builder] Add custom step for AOR tests..
Tue, Mar 17, 3:07 PM · Restricted Project, Restricted Project
PaulkaToast created D76330: [libc] Add AOR testing dependencies for buildbot workers..
Tue, Mar 17, 3:07 PM · Restricted Project
PaulkaToast committed rG17566573b299: [libc] Resolve race condition in sub-process test runner. (authored by PaulkaToast).
[libc] Resolve race condition in sub-process test runner.
Tue, Mar 17, 1:30 PM
PaulkaToast closed D76267: [libc] Resolve race condition in sub-process test runner..
Tue, Mar 17, 1:30 PM · Restricted Project
PaulkaToast updated the diff for D76267: [libc] Resolve race condition in sub-process test runner..

Add comment explaining why we wait on pid.

Tue, Mar 17, 12:57 PM · Restricted Project

Mon, Mar 16

PaulkaToast created D76267: [libc] Resolve race condition in sub-process test runner..
Mon, Mar 16, 10:00 PM · Restricted Project

Thu, Mar 12

PaulkaToast accepted D76089: [libc builder] Fix the asan option name..
Thu, Mar 12, 1:34 PM
PaulkaToast committed rGeb41cc619866: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check. (authored by PaulkaToast).
[clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.
Thu, Mar 12, 11:57 AM
PaulkaToast closed D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check..
Thu, Mar 12, 11:57 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 11

PaulkaToast committed rG270b528c7c5c: [libc] Add docker container for llvm-libc buildbot worker. (authored by PaulkaToast).
[libc] Add docker container for llvm-libc buildbot worker.
Wed, Mar 11, 5:37 PM
PaulkaToast closed D75596: [libc] Add docker container for llvm-libc buildbot worker..
Wed, Mar 11, 5:36 PM · Restricted Project
PaulkaToast updated the diff for D75596: [libc] Add docker container for llvm-libc buildbot worker..
Wed, Mar 11, 5:35 PM · Restricted Project
PaulkaToast updated the diff for D75596: [libc] Add docker container for llvm-libc buildbot worker..

Changed to install ninja from apt instead of source.

Wed, Mar 11, 5:35 PM · Restricted Project
PaulkaToast updated the diff for D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check..

Mocked the header files so that we don't experience failures due to differences in systems. Mind taking a quick look @aaron.ballman?

Wed, Mar 11, 5:03 PM · Restricted Project, Restricted Project, Restricted Project
PaulkaToast committed rGf1736f7a2a66: [clang-tidy] Mock system headers for portability-restrict-system-includes tests. (authored by PaulkaToast).
[clang-tidy] Mock system headers for portability-restrict-system-includes tests.
Wed, Mar 11, 12:30 PM
PaulkaToast closed D76015: [clang-tidy] Mock system headers for portability-restrict-system-includes tests..
Wed, Mar 11, 12:30 PM · Restricted Project, Restricted Project
PaulkaToast created D76015: [clang-tidy] Mock system headers for portability-restrict-system-includes tests..
Wed, Mar 11, 11:19 AM · Restricted Project, Restricted Project
PaulkaToast added a comment to D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use..

@PaulkaToast This patch appears to have caused a buildbot issue, please can you investigate/revert: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/63869

I believe the issue is that we're looking for system headers that are not mocked as part of the test. Sorry about not catching that earlier in the review! @PaulkaToast, you should create an empty stdio.h (and others used by your test) in Inputs/fucscia-restrict-system-includes/system so that we're not finding the actual system includes.

Wed, Mar 11, 10:09 AM · Restricted Project, Restricted Project

Tue, Mar 10

PaulkaToast updated the diff for D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check..

Addressed @Eugene.Zelenko comments.

Tue, Mar 10, 7:42 PM · Restricted Project, Restricted Project, Restricted Project
PaulkaToast added inline comments to D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check..
Tue, Mar 10, 6:37 PM · Restricted Project, Restricted Project, Restricted Project
PaulkaToast updated the diff for D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check..

Addressed @aaron.ballman comments (:

Tue, Mar 10, 6:37 PM · Restricted Project, Restricted Project, Restricted Project
PaulkaToast committed rG54928ba0ec83: [clang-tidy] Use more widely available headers for protability-restrict-system… (authored by PaulkaToast).
[clang-tidy] Use more widely available headers for protability-restrict-system…
Tue, Mar 10, 5:00 PM
PaulkaToast committed rGddfcda0256ca: [clang-tidy] Fix warning from my previous patch in ReleaseNotes.txt (authored by PaulkaToast).
[clang-tidy] Fix warning from my previous patch in ReleaseNotes.txt
Tue, Mar 10, 2:16 PM
PaulkaToast committed rGebdb98f254f6: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for… (authored by PaulkaToast).
[clang-tidy] Move fuchsia-restrict-system-includes to portability module for…
Tue, Mar 10, 1:41 PM
PaulkaToast closed D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use..
Tue, Mar 10, 1:41 PM · Restricted Project, Restricted Project
PaulkaToast added a comment to D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use..
Tue, Mar 10, 1:39 PM · Restricted Project, Restricted Project

Mon, Mar 9

PaulkaToast accepted D75651: [libc] [UnitTest] Add timeout to death tests.

This looks ready to me.
nit: I'd maybe add some comments explaining the pipe trick since it might not be overtly obvious what's happening here on first glance. (:

Mon, Mar 9, 7:26 PM · Restricted Project
PaulkaToast updated the summary of D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use..
Mon, Mar 9, 3:40 PM · Restricted Project, Restricted Project

Fri, Mar 6

PaulkaToast updated the diff for D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use..
Fri, Mar 6, 10:25 PM · Restricted Project, Restricted Project
PaulkaToast updated the diff for D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use..

Thanks for the heads up phosek, I removed the check from fuchsia's directory.
Also addressed Eurgene.Zelenko's comments. (:

Fri, Mar 6, 8:22 PM · Restricted Project, Restricted Project
PaulkaToast updated the diff for D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check..

Thanks for the suggestions, the general check sounds like a great idea. I can see the use case for this as it can be used by anyone. I took the time to port out fuchsia's check and flesh out the user facing documentation. Here is the patch for that D75786.

Fri, Mar 6, 4:34 PM · Restricted Project, Restricted Project, Restricted Project
PaulkaToast created D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use..
Fri, Mar 6, 4:34 PM · Restricted Project, Restricted Project

Thu, Mar 5

PaulkaToast accepted D75487: [libc] [UnitTest] Add Matchers.
Thu, Mar 5, 1:12 PM · Restricted Project
PaulkaToast added inline comments to D75651: [libc] [UnitTest] Add timeout to death tests.
Thu, Mar 5, 9:50 AM · Restricted Project

Wed, Mar 4

PaulkaToast created D75596: [libc] Add docker container for llvm-libc buildbot worker..
Wed, Mar 4, 12:06 AM · Restricted Project

Tue, Mar 3

PaulkaToast updated the diff for D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check..
Tue, Mar 3, 4:07 PM · Restricted Project, Restricted Project, Restricted Project
PaulkaToast added a comment to D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check..

RestrictSystemLibcHeadersCheck

As I commented previously, I think the checker name should be generalized, as it does not need to be coupled with llvm-libc. Other projects may have similar needs. For example, they don't want to accidentally include a system zlib.h -> they may ship a bundled zlib (say, in third_party/zlib/).

Maybe misc/ (or portability/) is more suitable?

Tue, Mar 3, 3:00 PM · Restricted Project, Restricted Project, Restricted Project
PaulkaToast updated the diff for D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check..
Tue, Mar 3, 3:00 PM · Restricted Project, Restricted Project, Restricted Project
PaulkaToast updated the diff for D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check..
Tue, Mar 3, 10:56 AM · Restricted Project, Restricted Project, Restricted Project
PaulkaToast accepted D75502: [libc] Add `errno_h` as a dependency to `sigaddset` and `sigemptyset`..
Tue, Mar 3, 12:00 AM · Restricted Project

Mon, Mar 2

PaulkaToast added a comment to D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check..

The test cases need fixing as they are causing the build to fail.

Done.

Also would it be wise to add a .clang-tidy file to libc/ to enable this module for that subdirectory?

Yes, this will be done in a separate patch. Thanks for pointing it out!

Mon, Mar 2, 11:09 PM · Restricted Project, Restricted Project, Restricted Project
PaulkaToast updated the diff for D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check..
Mon, Mar 2, 11:09 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Feb 28

PaulkaToast created D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check..
Fri, Feb 28, 12:32 AM · Restricted Project, Restricted Project, Restricted Project

Feb 26 2020

PaulkaToast committed rG52073310e443: [libc] Fix typo of namespace in round implementation. (authored by PaulkaToast).
[libc] Fix typo of namespace in round implementation.
Feb 26 2020, 12:27 PM
PaulkaToast closed D75205: [libc] Fix typo of namespace in round implementation..
Feb 26 2020, 12:27 PM · Restricted Project
PaulkaToast updated the summary of D75205: [libc] Fix typo of namespace in round implementation..
Feb 26 2020, 12:09 PM · Restricted Project
PaulkaToast created D75205: [libc] Fix typo of namespace in round implementation..
Feb 26 2020, 12:08 PM · Restricted Project

Feb 23 2020

PaulkaToast added a comment to D75027: [libc] Guard cmake policy to avoid errors on older versions of cmake..

Like @MaskRay suggests, would bumping LLVM-libc's minimum required version instead of this change help/unblock you?

Feb 23 2020, 9:21 PM · Restricted Project
PaulkaToast added a comment to D75027: [libc] Guard cmake policy to avoid errors on older versions of cmake..

Do those older versions still build fine without this policy being set?

Feb 23 2020, 7:42 PM · Restricted Project
PaulkaToast created D75027: [libc] Guard cmake policy to avoid errors on older versions of cmake..
Feb 23 2020, 6:57 PM · Restricted Project
PaulkaToast accepted D74502: [libc] Add a README to the sub-directories under the utils directory..
Feb 23 2020, 12:30 AM · Restricted Project

Feb 22 2020

PaulkaToast added inline comments to D74502: [libc] Add a README to the sub-directories under the utils directory..
Feb 22 2020, 2:16 PM · Restricted Project

Feb 21 2020

PaulkaToast committed rGa4f45ee73a9e: [libc] Lay out framework for fuzzing libc functions. (authored by PaulkaToast).
[libc] Lay out framework for fuzzing libc functions.
Feb 21 2020, 7:21 PM
PaulkaToast closed D74091: [libc] Lay out framework for fuzzing libc functions..
Feb 21 2020, 7:21 PM · Restricted Project
PaulkaToast added inline comments to D74091: [libc] Lay out framework for fuzzing libc functions..
Feb 21 2020, 7:11 PM · Restricted Project
PaulkaToast added inline comments to D74502: [libc] Add a README to the sub-directories under the utils directory..
Feb 21 2020, 6:44 PM · Restricted Project
PaulkaToast added inline comments to D74091: [libc] Lay out framework for fuzzing libc functions..
Feb 21 2020, 6:18 PM · Restricted Project
PaulkaToast added inline comments to D74091: [libc] Lay out framework for fuzzing libc functions..
Feb 21 2020, 6:00 PM · Restricted Project
PaulkaToast added inline comments to D74091: [libc] Lay out framework for fuzzing libc functions..
Feb 21 2020, 5:24 PM · Restricted Project
PaulkaToast updated the diff for D74091: [libc] Lay out framework for fuzzing libc functions..
Feb 21 2020, 5:24 PM · Restricted Project
PaulkaToast updated the diff for D74091: [libc] Lay out framework for fuzzing libc functions..

Removed most dependencies on system libc headers and integrated changes requested by Kostya.

Feb 21 2020, 2:48 PM · Restricted Project

Feb 14 2020

PaulkaToast committed rZORG117452ba0d90: [libc builder] Use annotated builder for libc buildbot. (authored by PaulkaToast).
[libc builder] Use annotated builder for libc buildbot.
Feb 14 2020, 10:49 AM
PaulkaToast closed D74199: [libc builder] Use annotated builder for libc buildbot..
Feb 14 2020, 10:49 AM · Restricted Project, Restricted Project