- User Since
- Jan 5 2020, 11:18 PM (11 w, 5 d)
Updated to handle nested namespaces, exclude C linkages functions, and made check language specific. (:
Thu, Mar 26
Won't deleting the files in the AOR directory cause the make check on the buildbots to fail? It might make sense to leave the files and delete them once all functions have been migrated?
Wed, Mar 25
Abandoning for a more generalized check. D76818
Tue, Mar 24
Mon, Mar 23
Sat, Mar 21
Fri, Mar 20
This seems to be causing a failure in our buildbot, mind taking a look? (:
Wed, Mar 18
Tue, Mar 17
Addressed comments. (:
Add comment explaining why we wait on pid.
Mon, Mar 16
Thu, Mar 12
Wed, Mar 11
Changed to install ninja from apt instead of source.
Mocked the header files so that we don't experience failures due to differences in systems. Mind taking a quick look @aaron.ballman?
Tue, Mar 10
Addressed @Eugene.Zelenko comments.
Addressed @aaron.ballman comments (:
Mon, Mar 9
This looks ready to me.
nit: I'd maybe add some comments explaining the pipe trick since it might not be overtly obvious what's happening here on first glance. (:
Fri, Mar 6
Thanks for the heads up phosek, I removed the check from fuchsia's directory.
Also addressed Eurgene.Zelenko's comments. (:
Thanks for the suggestions, the general check sounds like a great idea. I can see the use case for this as it can be used by anyone. I took the time to port out fuchsia's check and flesh out the user facing documentation. Here is the patch for that D75786.
Thu, Mar 5
Wed, Mar 4
Tue, Mar 3
Mon, Mar 2
Also would it be wise to add a .clang-tidy file to libc/ to enable this module for that subdirectory?
Yes, this will be done in a separate patch. Thanks for pointing it out!
Fri, Feb 28
Feb 26 2020
Feb 23 2020
Feb 22 2020
Feb 21 2020
Removed most dependencies on system libc headers and integrated changes requested by Kostya.