Page MenuHomePhabricator

PaulkaToast (Paula Toth)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 5 2020, 11:18 PM (37 w, 2 d)

Recent Activity

Jul 9 2020

PaulkaToast added inline comments to D83353: [libc] Add strchr implementation..
Jul 9 2020, 1:20 PM · Restricted Project

Jul 6 2020

PaulkaToast committed rGab25ed26c67e: [libc] Add documentation for clang-tidy checks. (authored by PaulkaToast).
[libc] Add documentation for clang-tidy checks.
Jul 6 2020, 6:16 PM
PaulkaToast closed D82846: [libc] Add documentation for clang-tidy checks..
Jul 6 2020, 6:16 PM · Restricted Project
PaulkaToast updated the diff for D82846: [libc] Add documentation for clang-tidy checks..
Jul 6 2020, 2:58 PM · Restricted Project
PaulkaToast added inline comments to D82873: Initial buildbot image for Windows with Visual Studio 2019.
Jul 6 2020, 12:57 PM
PaulkaToast committed rGaa6ef6fea0f0: [libc] Add documentation for integration tests. (authored by PaulkaToast).
[libc] Add documentation for integration tests.
Jul 6 2020, 12:45 PM
PaulkaToast closed D82907: [libc] Add documentation for integration tests..
Jul 6 2020, 12:45 PM · Restricted Project
PaulkaToast added inline comments to D82907: [libc] Add documentation for integration tests..
Jul 6 2020, 12:42 PM · Restricted Project
PaulkaToast updated the diff for D82907: [libc] Add documentation for integration tests..
Jul 6 2020, 12:42 PM · Restricted Project
PaulkaToast added inline comments to D82846: [libc] Add documentation for clang-tidy checks..
Jul 6 2020, 12:35 PM · Restricted Project
PaulkaToast updated the diff for D82846: [libc] Add documentation for clang-tidy checks..
Jul 6 2020, 12:35 PM · Restricted Project

Jun 30 2020

PaulkaToast created D82907: [libc] Add documentation for integration tests..
Jun 30 2020, 1:35 PM · Restricted Project
PaulkaToast created D82846: [libc] Add documentation for clang-tidy checks..
Jun 30 2020, 1:02 AM · Restricted Project

Jun 28 2020

PaulkaToast accepted D82427: [libc] Fix strcmp fuzz test to use one input..
Jun 28 2020, 11:19 AM · Restricted Project

Jun 26 2020

PaulkaToast accepted D82427: [libc] Fix strcmp fuzz test to use one input..

Minor nit, looks good otherwise. (:
If you haven't run git clang-format HEAD~1 before you land the patch.

Jun 26 2020, 5:20 PM · Restricted Project

Jun 22 2020

PaulkaToast accepted D82247: [libc] Add fuzz test for strcmp..

After comments are addressed LGTM but you might want to wait for approval from sivachandra.

Jun 22 2020, 7:52 PM · Restricted Project

Jun 18 2020

PaulkaToast added inline comments to D82134: [libc] Add strcmp implementation..
Jun 18 2020, 6:35 PM · Restricted Project

Jun 12 2020

PaulkaToast added inline comments to D81738: initial terraform configuration for Google buildbot workers.
Jun 12 2020, 2:14 PM
PaulkaToast added a comment to D81737: docker images for mlir-nvidia.

I don't know where is the best place for the Docker config to live, but there are some in the monorepo already FYI:

llvm-project/libcxx/utils/docker/debian9/buildbot/Dockerfile
llvm-project/clang/tools/clang-fuzzer/Dockerfile
llvm-project/libc/utils/buildbot/Dockerfile
llvm-project/llvm/utils/docker/debian8/Dockerfile
llvm-project/llvm/utils/docker/example/Dockerfile
llvm-project/llvm/utils/docker/nvidia-cuda/Dockerfile

Jun 12 2020, 1:43 PM · Restricted Project

Jun 10 2020

PaulkaToast committed rZORG6aed006d6304: [libc builder] Uncomment integration test step. (authored by PaulkaToast).
[libc builder] Uncomment integration test step.
Jun 10 2020, 10:39 PM
PaulkaToast committed rG0dcdc1c863eb: [libc] Fix integration test header dependency. (authored by PaulkaToast).
[libc] Fix integration test header dependency.
Jun 10 2020, 10:07 PM
PaulkaToast committed rZORG66528075e009: [libc builder] Comment out integration test step. (authored by PaulkaToast).
[libc builder] Comment out integration test step.
Jun 10 2020, 5:15 PM

Jun 2 2020

PaulkaToast committed rZORGd93182bd9603: [libc builder] Fix type in integration test command. (authored by PaulkaToast).
[libc builder] Fix type in integration test command.
Jun 2 2020, 6:08 PM
PaulkaToast committed rZORGfdece131fdcc: [libc builder] Add integration test step to non asan builds. (authored by PaulkaToast).
[libc builder] Add integration test step to non asan builds.
Jun 2 2020, 5:02 PM
PaulkaToast closed D81039: [libc builder] Add integration test step to non asan builds..
Jun 2 2020, 5:02 PM · Restricted Project
PaulkaToast created D81039: [libc builder] Add integration test step to non asan builds..
Jun 2 2020, 3:23 PM · Restricted Project
PaulkaToast committed rGd5e0dfd50704: [libc] Remove integration test target from check libc. (authored by PaulkaToast).
[libc] Remove integration test target from check libc.
Jun 2 2020, 1:46 PM
PaulkaToast closed D81029: [libc] Remove integration test target from check libc..
Jun 2 2020, 1:46 PM · Restricted Project
PaulkaToast updated the diff for D81029: [libc] Remove integration test target from check libc..
Jun 2 2020, 1:42 PM · Restricted Project
PaulkaToast created D81029: [libc] Remove integration test target from check libc..
Jun 2 2020, 1:42 PM · Restricted Project
PaulkaToast committed rGb836ae24a9f4: [libc] Add integration tests. (authored by PaulkaToast).
[libc] Add integration tests.
Jun 2 2020, 12:38 PM
PaulkaToast closed D79192: [libc] Add integration tests..
Jun 2 2020, 12:38 PM · Restricted Project
PaulkaToast added a comment to D79192: [libc] Add integration tests..
Jun 2 2020, 12:37 PM · Restricted Project

Jun 1 2020

PaulkaToast updated the diff for D79192: [libc] Add integration tests..
Jun 1 2020, 1:32 PM · Restricted Project
PaulkaToast committed rG1ab092b75859: [libc] Expose APIGenerator. (authored by PaulkaToast).
[libc] Expose APIGenerator.
Jun 1 2020, 1:01 PM
PaulkaToast closed D80832: [libc] Expose APIGenerator..
Jun 1 2020, 1:00 PM · Restricted Project
PaulkaToast updated the diff for D79192: [libc] Add integration tests..
Jun 1 2020, 12:59 PM · Restricted Project
PaulkaToast added inline comments to D80832: [libc] Expose APIGenerator..
Jun 1 2020, 12:29 AM · Restricted Project

May 31 2020

PaulkaToast updated the diff for D80832: [libc] Expose APIGenerator..
May 31 2020, 11:57 PM · Restricted Project

May 29 2020

PaulkaToast added inline comments to D79192: [libc] Add integration tests..
May 29 2020, 3:52 PM · Restricted Project
PaulkaToast updated the summary of D78700: [libc] Surround get_start_args_addr in __llvm_libc namespace..
May 29 2020, 3:52 PM · Restricted Project
PaulkaToast added inline comments to D79192: [libc] Add integration tests..
May 29 2020, 1:06 PM · Restricted Project
PaulkaToast updated the diff for D79192: [libc] Add integration tests..
May 29 2020, 1:06 PM · Restricted Project
PaulkaToast created D80832: [libc] Expose APIGenerator..
May 29 2020, 12:33 PM · Restricted Project

May 28 2020

PaulkaToast updated the diff for D79192: [libc] Add integration tests..
May 28 2020, 5:05 PM · Restricted Project
PaulkaToast added inline comments to D79192: [libc] Add integration tests..
May 28 2020, 5:05 PM · Restricted Project
PaulkaToast added a comment to D80495: Fixing the build command for benchmarks..

FWIW, we should do something about clang and clang-tools-extra being required. It also causes the Harbormaster builds to fail because it not longer builds all top level targets anymore.

May 28 2020, 1:45 PM · Restricted Project

May 27 2020

PaulkaToast updated the diff for D79192: [libc] Add integration tests..
May 27 2020, 7:39 PM · Restricted Project
PaulkaToast updated the diff for D79192: [libc] Add integration tests..
May 27 2020, 4:56 PM · Restricted Project
PaulkaToast updated the diff for D79192: [libc] Add integration tests..
May 27 2020, 12:30 AM · Restricted Project

May 26 2020

PaulkaToast added a comment to D79192: [libc] Add integration tests..

As for the Linux dev headers I think instead of a work around using clang-tidy, it might just be better to remove our dependency on the dev headers all together, especially since the dev headers differ between platforms such as sigset_t on AARCH64 vs x86.
I can send out a separate patch out for this as well.

What do you mean remove the dependency on dev headers? Does it mean that we make copies of linux definitions in LLVM libc tree?

May 26 2020, 8:42 PM · Restricted Project
PaulkaToast updated the diff for D79192: [libc] Add integration tests..
May 26 2020, 8:42 PM · Restricted Project

May 21 2020

PaulkaToast committed rG2a4c30985ded: [libc] Make clang-tidy use host compiler's resource dir. (authored by PaulkaToast).
[libc] Make clang-tidy use host compiler's resource dir.
May 21 2020, 6:58 PM
PaulkaToast closed D80265: [libc] Make clang-tidy use host compiler's resource dir..
May 21 2020, 6:57 PM · Restricted Project
PaulkaToast updated the diff for D80265: [libc] Make clang-tidy use host compiler's resource dir..
May 21 2020, 4:49 PM · Restricted Project
PaulkaToast added inline comments to D80265: [libc] Make clang-tidy use host compiler's resource dir..
May 21 2020, 4:49 PM · Restricted Project
PaulkaToast updated the diff for D80265: [libc] Make clang-tidy use host compiler's resource dir..
May 21 2020, 4:49 PM · Restricted Project
PaulkaToast updated the diff for D80265: [libc] Make clang-tidy use host compiler's resource dir..
May 21 2020, 4:16 PM · Restricted Project
PaulkaToast committed rGb2a485e37edf: [libc] Fix accidental inclusion of system libc headers. (authored by PaulkaToast).
[libc] Fix accidental inclusion of system libc headers.
May 21 2020, 2:08 AM
PaulkaToast closed D80178: [libc] Fix accidental inclusion of system libc headers..
May 21 2020, 2:08 AM · Restricted Project
PaulkaToast updated the summary of D80178: [libc] Fix accidental inclusion of system libc headers..
May 21 2020, 12:31 AM · Restricted Project

May 20 2020

PaulkaToast updated the diff for D80178: [libc] Fix accidental inclusion of system libc headers..
May 20 2020, 11:58 PM · Restricted Project
PaulkaToast added inline comments to D80265: [libc] Make clang-tidy use host compiler's resource dir..
May 20 2020, 11:25 PM · Restricted Project
PaulkaToast added inline comments to D80178: [libc] Fix accidental inclusion of system libc headers..
May 20 2020, 11:06 PM · Restricted Project
PaulkaToast added a comment to D79192: [libc] Add integration tests..

Sorry for the delayed response!

May 20 2020, 9:29 PM · Restricted Project

May 19 2020

PaulkaToast created D80265: [libc] Make clang-tidy use host compiler's resource dir..
May 19 2020, 7:49 PM · Restricted Project

May 18 2020

PaulkaToast committed rZORGea71685b0b17: [libc builder] Add benchmark util tests step to release builder (authored by PaulkaToast).
[libc builder] Add benchmark util tests step to release builder
May 18 2020, 10:45 PM
PaulkaToast closed D80162: [libc builder] Add benchmark util tests step to release builder.
May 18 2020, 10:45 PM · Restricted Project, Restricted Project
PaulkaToast updated the diff for D80178: [libc] Fix accidental inclusion of system libc headers..
May 18 2020, 10:45 PM · Restricted Project
PaulkaToast updated the summary of D80178: [libc] Fix accidental inclusion of system libc headers..
May 18 2020, 10:45 PM · Restricted Project
PaulkaToast added a comment to D80178: [libc] Fix accidental inclusion of system libc headers..

Doesn't this trigger a "defining builtin macro" warning/error?
Does adding -ffreestanding to the compile step of the raw object file fix the problem you are seeing and also avoid tampering with __STDC_HOSTED__ macro?

May 18 2020, 10:45 PM · Restricted Project
PaulkaToast created D80178: [libc] Fix accidental inclusion of system libc headers..
May 18 2020, 9:40 PM · Restricted Project
PaulkaToast created D80162: [libc builder] Add benchmark util tests step to release builder.
May 18 2020, 2:39 PM · Restricted Project, Restricted Project

May 8 2020

PaulkaToast committed rZORGa8163553201f: [zorg] Add builder for release build. (authored by PaulkaToast).
[zorg] Add builder for release build.
May 8 2020, 3:04 PM
PaulkaToast closed D79461: [zorg] Add builder for release build..
May 8 2020, 3:04 PM · Restricted Project
PaulkaToast added a comment to D79461: [zorg] Add builder for release build..

Gotcha thanks!

May 8 2020, 2:32 PM · Restricted Project

May 7 2020

PaulkaToast added inline comments to D79192: [libc] Add integration tests..
May 7 2020, 8:04 PM · Restricted Project
PaulkaToast updated the summary of D79192: [libc] Add integration tests..
May 7 2020, 8:04 PM · Restricted Project
PaulkaToast updated the diff for D79192: [libc] Add integration tests..
May 7 2020, 8:04 PM · Restricted Project
PaulkaToast committed rGbf6f3894c4a8: [libc] Fix warnings on release build. (authored by PaulkaToast).
[libc] Fix warnings on release build.
May 7 2020, 11:58 AM
PaulkaToast closed D79469: [libc] Fix warnings on release build..
May 7 2020, 11:57 AM · Restricted Project
PaulkaToast abandoned D77281: [libc] Add libc-tidy..

Abandoned in favor of D79192.

May 7 2020, 3:21 AM · Restricted Project
PaulkaToast added a comment to D79192: [libc] Add integration tests..
  • Instead of creating a target for every entrypoint, have you considered generating a single file which:
    1. Includes all header files listed in the api.td.
    2. Lists cpp:Function pointers to all functions as required by api.td.

There definitely are problems that need to be solved with this approach. For example, how do you ensure all public header files are already present in the build/.../libc/include directory. But, the appeal of this approach is that one does not have to create explicit or implicit targets for "integration tests". There would be just one target which would test everything in one go.

May 7 2020, 2:48 AM · Restricted Project
PaulkaToast updated the diff for D79192: [libc] Add integration tests..
May 7 2020, 2:48 AM · Restricted Project

May 6 2020

PaulkaToast committed rGd80715d1d466: [libc] Change target name for testing benchmark utils infrastructure. (authored by PaulkaToast).
[libc] Change target name for testing benchmark utils infrastructure.
May 6 2020, 1:35 AM
PaulkaToast closed D79466: [libc] Change target name for testing benchmark utils infrastructure..
May 6 2020, 1:35 AM · Restricted Project
PaulkaToast updated the diff for D79469: [libc] Fix warnings on release build..
May 6 2020, 1:34 AM · Restricted Project
PaulkaToast updated the diff for D79461: [zorg] Add builder for release build..
May 6 2020, 1:34 AM · Restricted Project
PaulkaToast updated the diff for D79466: [libc] Change target name for testing benchmark utils infrastructure..
May 6 2020, 1:34 AM · Restricted Project
PaulkaToast added a reviewer for D79461: [zorg] Add builder for release build.: gkistanova.
May 6 2020, 1:02 AM · Restricted Project

May 5 2020

PaulkaToast abandoned D76978: [libc builder] Add custom step to run clang-tidy..

No longer needed as this is achieved with cmake rules.

May 5 2020, 10:37 PM · Restricted Project, Restricted Project
PaulkaToast created D79469: [libc] Fix warnings on release build..
May 5 2020, 10:37 PM · Restricted Project
PaulkaToast created D79466: [libc] Change target name for testing benchmark utils infrastructure..
May 5 2020, 7:26 PM · Restricted Project
PaulkaToast created D79461: [zorg] Add builder for release build..
May 5 2020, 6:22 PM · Restricted Project

May 2 2020

PaulkaToast accepted D79185: [libc] Include object files from alias entrypoints also in entrypoint libraries..
May 2 2020, 3:08 AM · Restricted Project

Apr 30 2020

PaulkaToast created D79192: [libc] Add integration tests..
Apr 30 2020, 11:47 AM · Restricted Project

Apr 28 2020

PaulkaToast committed rG8683f5de5352: [clang-tidy] Add check callee-namespace. (authored by PaulkaToast).
[clang-tidy] Add check callee-namespace.
Apr 28 2020, 5:50 PM
PaulkaToast closed D78890: [clang-tidy] Add check callee-namespace..
Apr 28 2020, 5:50 PM · Restricted Project, Restricted Project, Restricted Project
PaulkaToast added inline comments to D78890: [clang-tidy] Add check callee-namespace..
Apr 28 2020, 5:50 PM · Restricted Project, Restricted Project, Restricted Project
PaulkaToast updated the diff for D78890: [clang-tidy] Add check callee-namespace..
Apr 28 2020, 5:50 PM · Restricted Project, Restricted Project, Restricted Project