Page MenuHomePhabricator

[libc] Add spec for sigdelset and sigfillset.
ClosedPublic

Authored by PaulkaToast on Apr 23 2020, 4:50 AM.

Details

Summary

Caught by libc-tidy from patch D77281.

Diff Detail

Event Timeline

PaulkaToast created this revision.Apr 23 2020, 4:50 AM

Oops, thanks for fixing this

Could we also add these in libc/lib/CMakeLists.txt which I also forgot?

libc/spec/posix.td
186

Oops, thanks for adding that!

192

sigfillset doesn't take a second int.

PaulkaToast marked 3 inline comments as done.
PaulkaToast added inline comments.
libc/spec/posix.td
192

Oops!

PaulkaToast marked an inline comment as done.

Add to lib CMakeLists.

abrachet accepted this revision.Apr 23 2020, 3:48 PM

Thanks!

This revision is now accepted and ready to land.Apr 23 2020, 3:48 PM
This revision was automatically updated to reflect the committed changes.

You can delete unneeded Phabricator tags (Reviewers: Tags: Subscribers:) with:

arcfilter () {
        arc amend
        git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend -F -
}