This is an archive of the discontinued LLVM Phabricator instance.

Differential D78671

[mlir/Quant] Allows to use 32 bits storage type
ClosedPublic

Authored by liufengdb on Apr 22 2020, 2:16 PM.

Details

Reviewers
antiagainst
stellaraccident
Commits
rGb578c92a9898: [mlir/Quant] Allows to use 32 bits storage type

Diff Detail

Event Timeline

liufengdb created this revision.Apr 22 2020, 2:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2020, 2:16 PM
Herald added subscribers: llvm-commits, Kayjukh, frgossen and 11 others. · View Herald Transcript
liufengdb added a reviewer: antiagainst.Apr 22 2020, 2:18 PM
liufengdb removed a subscriber: llvm-commits.
liufengdb added a reviewer: stellaraccident.Apr 22 2020, 2:28 PM
Harbormaster failed remote builds in B54309: Diff 259396!Apr 22 2020, 3:48 PM
stellaraccident accepted this revision.Apr 22 2020, 8:32 PM
This revision is now accepted and ready to land.Apr 22 2020, 8:32 PM
Closed by commit rGb578c92a9898: [mlir/Quant] Allows to use 32 bits storage type (authored by liufengdb). · Explain WhyApr 23 2020, 11:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
lib/
Dialect/
Quant/
Utils/
9 lines

Diff 259396

mlir/lib/Dialect/Quant/Utils/FakeQuantSupport.cpp

Show All 29 Lines if (numBits <= 8) {
storageType = IntegerType::get(16, ctx); storageType = IntegerType::get(16, ctx);
if (isSigned) { if (isSigned) {
qmin = -32768; qmin = -32768;
qmax = 32767; qmax = 32767;
} else { } else {
qmin = 0; qmin = 0;
qmax = 65535; qmax = 65535;
} }
} else if (numBits <= 32) {
storageType = IntegerType::get(32, ctx);
if (isSigned) {
qmin = std::numeric_limits<int32_t>::min();
qmax = std::numeric_limits<int32_t>::max();
} else {
qmin = std::numeric_limits<uint32_t>::min();
qmax = std::numeric_limits<uint32_t>::max();
}
} else { } else {
return true; return true;
} }
// Handle narrowRange. // Handle narrowRange.
if (narrowRange) { if (narrowRange) {
qmin += 1; qmin += 1;
} }
▲ Show 20 Lines • Show All 130 Lines • Show Last 20 Lines