This is an archive of the discontinued LLVM Phabricator instance.

[SVE] Add Scalable vector support to C api

Authored by ctetreau on Apr 21 2020, 4:42 PM.

Diff Detail

Event Timeline

ctetreau created this revision.Apr 21 2020, 4:42 PM
Herald added a reviewer: efriedma. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript

This is sort of just an MVP first draft of the C api support. This basically implements the original C++ api. This is a little better though because LLVMVectorType does not have the default IsScalable = true parameter.

I'm unsure of how much value exposing FixedVectorType and ScalableVectorType through the C api would have given the fact that everything is passed around by a LLVMTypeRef handle. This requires some more thought.

ctetreau abandoned this revision.May 29 2020, 11:53 AM
CodaFi added a subscriber: CodaFi.EditedMay 31 2020, 2:40 PM

I see you’ve already abandoned the revision, but I want to say that if you wish to do this, please make a separate entry point in the C API for creating scalable vectors. We are still committed to ABI stability in the core bindings.