Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[SVE] Add Scalable vector support to C api
AbandonedPublic
Actions

Authored by ctetreau on Apr 21 2020, 4:42 PM.

Details

Reviewers

deadalnix
efriedma
kmclaughlin
sdesmalen

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	4,140 ms	LLVM.Bindings/Go::Unknown Unit Message ("")
	11,200 ms	lldb-api.commands/expression/import-std-module/basic::Unknown Unit Message ("")
	3,430 ms	lldb-api.commands/expression/import-std-module/conflicts::Unknown Unit Message ("")
	5,470 ms	lldb-api.commands/expression/import-std-module/deque-basic::Unknown Unit Message ("")
	5,530 ms	lldb-api.commands/expression/import-std-module/deque-dbg-info-content::Unknown Unit Message ("")
		View Full Test Results (42 Failed)

Event Timeline

ctetreau created this revision.Apr 21 2020, 4:42 PM

Herald added a reviewer: deadalnix. · View Herald TranscriptApr 21 2020, 4:42 PM

Herald added a reviewer: efriedma. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: llvm-commits, psnobl, rkruppe and 2 others. · View Herald Transcript

This is sort of just an MVP first draft of the C api support. This basically implements the original C++ api. This is a little better though because LLVMVectorType does not have the default IsScalable = true parameter.

I'm unsure of how much value exposing FixedVectorType and ScalableVectorType through the C api would have given the fact that everything is passed around by a LLVMTypeRef handle. This requires some more thought.

ctetreau added a parent revision: D77587: [SVE] Add new VectorType subclasses.Apr 21 2020, 4:46 PM

ctetreau added reviewers: kmclaughlin, sdesmalen.Apr 21 2020, 5:08 PM

Harbormaster failed remote builds in B54172: Diff 259129!Apr 21 2020, 5:21 PM

ctetreau removed a parent revision: D77587: [SVE] Add new VectorType subclasses.Apr 23 2020, 10:56 AM

ctetreau abandoned this revision.May 29 2020, 11:53 AM

I see you’ve already abandoned the revision, but I want to say that if you wish to do this, please make a separate entry point in the C API for creating scalable vectors. We are still committed to ABI stability in the core bindings.