This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Remove vscode plugin: now https://github.com/clangd/vscode-clangd
ClosedPublic

Authored by sammccall on Apr 21 2020, 4:29 PM.

Details

Summary

Moving this out of the monorepo for consistency with other editor plugins.
There's no version lock with clangd itself, and we never ran tests with lit.

The first version from the new repo has been published.

Diff Detail

Event Timeline

sammccall created this revision.Apr 21 2020, 4:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2020, 4:29 PM
nridge added a subscriber: nridge.EditedApr 21 2020, 8:01 PM

Is there an easy way to transplant patches written against the old repo, into the new one?

hokein accepted this revision.Apr 22 2020, 12:05 AM

Thanks for doing it.

This revision is now accepted and ready to land.Apr 22 2020, 12:05 AM

Is there an easy way to transplant patches written against the old repo, into the new one?

I don't know whether there is an easy way, I'd just copy the changed file from the old repo to new repo, and regenerate a diff, I think this is not too terrible given that we don't have too much source files in our extension.

Is there an easy way to transplant patches written against the old repo, into the new one?

If you have a patch file (from git format-patch or downloaded from phab), you should be able to use patch -p

cd vscode-clangd # new repo
patch -p5 < old.patch

Where -p1 strips off the conventional a/ vs b/ diff prefix, and the other 4 is for clang-tools-extra/clangd/clients/clangd-vscode.
Disclaimer: haven't tried this, may be off-by-one. Sorry for the hassle!

This revision was automatically updated to reflect the committed changes.

Also, does this mean that patches to vscode-clangd should now be submitted as a Github PR rather than via Phabricator?

clang-tools-extra/clangd/clients/clangd-vscode/test/semantic-highlighting.test.ts