The test in question uses a non-portable grep -A option in conjunction with wc -l. FileCheck can be used to do the check without using these extra utilities.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Time | Test | |
---|---|---|
50 ms | MLIR.Target::Unknown Unit Message ("") |
Event Timeline
Comment Actions
Seems fine, but lots of other tests probably need grep and wc? What's the motivation for this? (But if solves some problem for you, fine to land. Just curious.)
Comment Actions
Portable use of grep and wc is probably fine. The issue is that grep -A is not a valid option on the system I'm using. I checked, and the option is not standardized.