This is an archive of the discontinued LLVM Phabricator instance.

[test][NFC] Use plain FileCheck in statepoint-stackmap-size.ll
ClosedPublic

Authored by hubert.reinterpretcast on Apr 13 2020, 3:01 PM.

Details

Summary

The test in question uses a non-portable grep -A option in conjunction with wc -l. FileCheck can be used to do the check without using these extra utilities.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2020, 3:01 PM
thakis accepted this revision.Apr 14 2020, 4:51 PM

Seems fine, but lots of other tests probably need grep and wc? What's the motivation for this? (But if solves some problem for you, fine to land. Just curious.)

This revision is now accepted and ready to land.Apr 14 2020, 4:51 PM

Seems fine, but lots of other tests probably need grep and wc? What's the motivation for this? (But if solves some problem for you, fine to land. Just curious.)

Portable use of grep and wc is probably fine. The issue is that grep -A is not a valid option on the system I'm using. I checked, and the option is not standardized.

This revision was automatically updated to reflect the committed changes.