This is an archive of the discontinued LLVM Phabricator instance.

GlobalISel: Fix casted unmerge of G_CONCAT_VECTORS
ClosedPublic

Authored by arsenm on Apr 11 2020, 12:28 PM.

Details

Summary

This was assuming a scalarizing unmerge, and would fail assert if the
unmerge was to smaller vector types.

Diff Detail

Event Timeline

arsenm created this revision.Apr 11 2020, 12:28 PM
aemerson accepted this revision.Apr 13 2020, 5:17 PM

LGTM with nits.

llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h
469

typo converssions

llvm/include/llvm/Support/LowLevelTypeImpl.h
150

Can we assert that the type is divisible by Factor?

This revision is now accepted and ready to land.Apr 13 2020, 5:17 PM