Page MenuHomePhabricator

Fixing llvm-shlib to check for the correct host triple on Windows x86
AcceptedPublic

Authored by tannergooding on Apr 11 2020, 9:05 AM.

Details

Summary

As per https://bugs.llvm.org/show_bug.cgi?id=44127, the CMakeLists.txt for LLVM-C currently checks the wrong host-triple for Windows X86. This results in the official LLVM-C.dll binary being only 9kb in size and containing no exports.

This updates the check to use i686-pc-windows-msvc, which is the default triplet selected by CMake, so that the resulting binaries are as expected.

Diff Detail

Event Timeline

tannergooding created this revision.Apr 11 2020, 9:05 AM
whitequark resigned from this revision.Apr 11 2020, 9:40 AM

I am no longer maintaining the C API.

Wallbraker accepted this revision.Apr 28 2020, 3:50 AM
Wallbraker added a subscriber: Wallbraker.

Thank you for this patch, this looks good to me. But I do not have commit access to can not commit it.

This revision is now accepted and ready to land.Apr 28 2020, 3:50 AM