This is an archive of the discontinued LLVM Phabricator instance.

Differential D77903

[SVE] Remove calls to getBitWidth from clang
ClosedPublic

Authored by ctetreau on Apr 10 2020, 1:43 PM.

Details

Reviewers
efriedma
Commits
rG670f2f694bba: [SVE] Remove calls to getBitWidth from clang

Diff Detail

Unit TestsFailed

TimeTest
40 msMLIR.Target::Unknown Unit Message ("")

Event Timeline

ctetreau created this revision.Apr 10 2020, 1:43 PM
Herald added a reviewer: efriedma. · View Herald TranscriptApr 10 2020, 1:43 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. · View Herald Transcript
ctetreau added a parent revision: D77587: [SVE] Add new VectorType subclasses.Apr 10 2020, 2:03 PM
ctetreau added a child revision: D77833: [SVE] Remove VectorType::getBitWidth().
Harbormaster failed remote builds in B52732: Diff 256654!Apr 10 2020, 2:32 PM
efriedma accepted this revision.Apr 10 2020, 2:46 PM

LGTM

This revision is now accepted and ready to land.Apr 10 2020, 2:46 PM
ctetreau removed a parent revision: D77587: [SVE] Add new VectorType subclasses.Apr 13 2020, 4:55 PM
ctetreau updated this revision to Diff 257162.Apr 13 2020, 5:03 PM

rebase

Harbormaster failed remote builds in B53040: Diff 257162!Apr 13 2020, 6:05 PM
Closed by commit rG670f2f694bba: [SVE] Remove calls to getBitWidth from clang (authored by ctetreau). · Explain WhyApr 14 2020, 1:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
lib/
CodeGen/
5 lines

Diff 257162

clang/lib/CodeGen/TargetInfo.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 964 Lines • ▼ Show 20 Lines
static llvm::Type* X86AdjustInlineAsmType(CodeGen::CodeGenFunction &CGF, static llvm::Type* X86AdjustInlineAsmType(CodeGen::CodeGenFunction &CGF,
StringRef Constraint, StringRef Constraint,
llvm::Type* Ty) { llvm::Type* Ty) {
bool IsMMXCons = llvm::StringSwitch<bool>(Constraint) bool IsMMXCons = llvm::StringSwitch<bool>(Constraint)
.Cases("y", "&y", "^Ym", true) .Cases("y", "&y", "^Ym", true)
.Default(false); .Default(false);
if (IsMMXCons && Ty->isVectorTy()) { if (IsMMXCons && Ty->isVectorTy()) {
if (cast<llvm::VectorType>(Ty)->getBitWidth() != 64) { if (cast<llvm::VectorType>(Ty)->getPrimitiveSizeInBits().getFixedSize() !=
64) {
// Invalid MMX constraint // Invalid MMX constraint
return nullptr; return nullptr;
} }
return llvm::Type::getX86_MMXTy(CGF.getLLVMContext()); return llvm::Type::getX86_MMXTy(CGF.getLLVMContext());
} }
// No operation needed // No operation needed
▲ Show 20 Lines • Show All 1,273 Lines • ▼ Show 20 Linespublic:
bool isPassedUsingAVXType(QualType type) const { bool isPassedUsingAVXType(QualType type) const {
unsigned neededInt, neededSSE; unsigned neededInt, neededSSE;
// The freeIntRegs argument doesn't matter here. // The freeIntRegs argument doesn't matter here.
ABIArgInfo info = classifyArgumentType(type, 0, neededInt, neededSSE, ABIArgInfo info = classifyArgumentType(type, 0, neededInt, neededSSE,
/*isNamedArg*/true); /*isNamedArg*/true);
if (info.isDirect()) { if (info.isDirect()) {
llvm::Type *ty = info.getCoerceToType(); llvm::Type *ty = info.getCoerceToType();
if (llvm::VectorType *vectorTy = dyn_cast_or_null<llvm::VectorType>(ty)) if (llvm::VectorType *vectorTy = dyn_cast_or_null<llvm::VectorType>(ty))
return (vectorTy->getBitWidth() > 128); return vectorTy->getPrimitiveSizeInBits().getFixedSize() > 128;
} }
return false; return false;
} }
void computeInfo(CGFunctionInfo &FI) const override; void computeInfo(CGFunctionInfo &FI) const override;
Address EmitVAArg(CodeGenFunction &CGF, Address VAListAddr, Address EmitVAArg(CodeGenFunction &CGF, Address VAListAddr,
QualType Ty) const override; QualType Ty) const override;
▲ Show 20 Lines • Show All 8,209 Lines • Show Last 20 Lines