This is an archive of the discontinued LLVM Phabricator instance.

Differential D77876

Normalize working directory when running llvm-mc
ClosedPublic

Authored by serge-sans-paille on Apr 10 2020, 6:57 AM.

Details

Reviewers
JDevlieghere
tstellar
Commits
rGbab5908df544: Normalize working directory when running llvm-mc in test
Summary

Otherwise, depending on the lit location used to run the test, llvm-mc adds an include_directories entry in the dwarf output, which breaks tests in some setup.

Diff Detail

Event Timeline

serge-sans-paille created this revision.Apr 10 2020, 6:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2020, 6:57 AM
Herald added subscribers: llvm-commits, aprantl. · View Herald Transcript
Harbormaster failed remote builds in B52672: Diff 256562!Apr 10 2020, 7:55 AM
serge-sans-paille updated this revision to Diff 256642.Apr 10 2020, 1:18 PM
Harbormaster failed remote builds in B52721: Diff 256642!Apr 10 2020, 1:59 PM
JDevlieghere accepted this revision.Apr 10 2020, 2:30 PM
This revision is now accepted and ready to land.Apr 10 2020, 2:30 PM
Closed by commit rGbab5908df544: Normalize working directory when running llvm-mc in test (authored by serge-sans-paille). · Explain WhyApr 13 2020, 4:48 AM
This revision was automatically updated to reflect the committed changes.
serge-sans-paille added a comment.Apr 13 2020, 7:09 AM

Thanks @JDevlieghere o/

MaskRay added a subscriber: MaskRay.Apr 13 2020, 11:42 AM

Otherwise, depending on the lit location used to run the test, llvm-mc adds an include_directories entry in the dwarf output, which breaks tests in some setup.

Do you know under what exact condition this happens? We need it for a better test comment...

serge-sans-paille added a comment.Apr 13 2020, 11:45 PM
In D77876#1978452, @MaskRay wrote:

Otherwise, depending on the lit location used to run the test, llvm-mc adds an include_directories entry in the dwarf output, which breaks tests in some setup.

Do you know under what exact condition this happens? We need it for a better test comment...

yes, I can provide the full setup, basically:

  1. run the testsuite to have all the.script file generated: lit -sv ${llvmproject_srcdir}/_build/test/MC/MachO --filter gen-dwarf.s
  2. go to test directory, for hacking: cd ${llvmproject_dir}/llvm/test/MC/MachO
  3. run the .script file by hand from that directory: sh ${llvmproject_srcdir}/_build/test/MC/MachO/Output/gen-dwarf.s.script
MaskRay added a comment.Apr 14 2020, 10:32 AM
In D77876#1979801, @serge-sans-paille wrote:
In D77876#1978452, @MaskRay wrote:

Otherwise, depending on the lit location used to run the test, llvm-mc adds an include_directories entry in the dwarf output, which breaks tests in some setup.

Do you know under what exact condition this happens? We need it for a better test comment...

yes, I can provide the full setup, basically:

  1. run the testsuite to have all the.script file generated: lit -sv ${llvmproject_srcdir}/_build/test/MC/MachO --filter gen-dwarf.s
  2. go to test directory, for hacking: cd ${llvmproject_dir}/llvm/test/MC/MachO
  3. run the .script file by hand from that directory: sh ${llvmproject_srcdir}/_build/test/MC/MachO/Output/gen-dwarf.s.script

Thanks for sharing the setup! If the directory name of gen-dwarf.s is the same as the current working directory (DW_AT_comp_dir), dir_index is 0, otherwise dir_index is 1. MCDwarf.cpp's behavior is consistent with GNU as -g here.

Revision Contents

PathSize
llvm/
test/
MC/
MachO/
2 lines

Diff 256961

llvm/test/MC/MachO/gen-dwarf.s

// RUN: llvm-mc -g -triple i386-apple-darwin10 %s -filetype=obj -o %t // RUN: mkdir -p %t0 && cd %t0 && llvm-mc -g -triple i386-apple-darwin10 %s -filetype=obj -o %t
// RUN: llvm-dwarfdump -all %t | FileCheck %s // RUN: llvm-dwarfdump -all %t | FileCheck %s
.globl _bar .globl _bar
_bar: _bar:
movl $0, %eax movl $0, %eax
L1: leave L1: leave
ret ret
_foo: _foo:
▲ Show 20 Lines • Show All 113 Lines • Show Last 20 Lines