This is an archive of the discontinued LLVM Phabricator instance.

All libc++ tests without an assert: .pass.cpp -> .compile.pass.cpp
AbandonedPublic

Authored by zoecarver on Apr 9 2020, 2:05 PM.

Details

Reviewers
ldionne
EricWF
mclow.lists
jfb
Group Reviewers
Restricted Project
Summary

Tests with the extension .compile.pass.cpp will pass the compiler -fsyntax-only which will make the compile / link / execution times significantly better. This patch bulk moves tests without any assertions from being .pass.cpp to .compile.pass.cpp.

Diff Detail

Event Timeline

zoecarver created this revision.Apr 9 2020, 2:05 PM
Herald added a reviewer: ldionne. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
zoecarver edited the summary of this revision. (Show Details)Apr 9 2020, 2:10 PM
zoecarver edited reviewers, added: EricWF, mclow.lists; removed: jfb.
ldionne requested changes to this revision.Apr 9 2020, 2:25 PM

At least some of these files don't contain any assertion visible in the test file, however they do run some code in main(). The tests that we can afford to compile only are those that really don't do anything at runtime, i.e. they only contain static_asserts or similar.

This revision now requires changes to proceed.Apr 9 2020, 2:25 PM

@ldionne should have put something here, sorry. Shortly after I created this revision I realized 1) that some of these tests need to be run and 2) that I had also missed all tests with static_asserts in them. I'm working on a more complicated script that will hopefully do a better job. Stay tuned :)

zoecarver abandoned this revision.May 2 2020, 4:27 PM