This is an archive of the discontinued LLVM Phabricator instance.

Differential D77733

[libunwind] Enable the new libc++ testing format by default
ClosedPublic

Authored by ldionne on Apr 8 2020, 7:53 AM.

Details

Reviewers
mstorsjo
MaskRay
Group Reviewers
Restricted Project
Commits
rG5f7a03016286: [libunwind] Enable the new libc++ testing format by default
Summary

The new format should be equivalent to the old format, and it is now the
default format when running the libc++ and libc++abi tests. This commit
changes the libunwind tests to use the new format by default too. If
unexpected failures are discovered, it should be fine to revert this
commit until they are addressed.

Also note that it is still possible to use the old format by passing
--param=use_old_format=True when running Lit for the time being.

Diff Detail

Event Timeline

ldionne created this revision.Apr 8 2020, 7:53 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 8 2020, 7:53 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added subscribers: libcxx-commits, llvm-commits, dexonsmith, jkorous. · View Herald Transcript
Harbormaster completed remote builds in B52361: Diff 256024.Apr 8 2020, 8:40 AM
ldionne added a comment.Apr 13 2020, 9:02 AM

Gentle ping!

mstorsjo accepted this revision.Apr 13 2020, 10:03 AM
mstorsjo added a subscriber: mstorsjo.

LGTM

This revision is now accepted and ready to land.Apr 13 2020, 10:03 AM
MaskRay accepted this revision.Apr 13 2020, 3:13 PM
MaskRay added a subscriber: MaskRay.

Related: D77338

This is nice! libunwind has (sadly) hardly any test currently...

Closed by commit rG5f7a03016286: [libunwind] Enable the new libc++ testing format by default (authored by ldionne). · Explain WhyApr 13 2020, 3:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
libunwind/
test/
9 lines

Diff 256024

libunwind/test/lit.cfg

Show First 20 Lines • Show All 61 Lines • ▼ Show 20 Lines
# Load the Configuration class from the module name <cfg_variant>.test.config. # Load the Configuration class from the module name <cfg_variant>.test.config.
config_module_name = '.'.join([cfg_variant, 'test', 'config']) config_module_name = '.'.join([cfg_variant, 'test', 'config'])
config_module = __import__(config_module_name, fromlist=['Configuration']) config_module = __import__(config_module_name, fromlist=['Configuration'])
configuration = config_module.Configuration(lit_config, config) configuration = config_module.Configuration(lit_config, config)
configuration.configure() configuration.configure()
configuration.print_config_info() configuration.print_config_info()
if lit_config.params.get('use_new_format', False): if lit_config.params.get('use_old_format', False):
lit_config.note("Using the experimental libc++ testing format") lit_config.note("Using the old libc++ testing format")
config.test_format = configuration.get_test_format()
else:
lit_config.note("Using the new libc++ testing format")
import libcxx.test.newformat import libcxx.test.newformat
config.test_format = libcxx.test.newformat.CxxStandardLibraryTest() config.test_format = libcxx.test.newformat.CxxStandardLibraryTest()
else:
config.test_format = configuration.get_test_format()