Page MenuHomePhabricator

[llvm-objdump][NFC] MachODump.cpp interface cleanup
ClosedPublic

Authored by hubert.reinterpretcast on Apr 8 2020, 7:03 AM.

Details

Summary

Continuing from D77388, this patch moves interface declarations associated with MachODump.cpp into the headers corresponding to the file that defines the variable. At the same time, these externs are moved into the llvm::objdump namespace. The externs defined in MachODump.cpp that are not referenced outside of it are given internal linkage.

This patch does not rename the external functions defined by MachODump.cpp that are not clearly named as being specific to Mach-O.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2020, 7:03 AM
Herald added a subscriber: rupprecht. · View Herald Transcript
MaskRay accepted this revision.Apr 8 2020, 11:21 AM

LGTM. Thanks for making the main llvm-objdump.h interface simpler.

This revision is now accepted and ready to land.Apr 8 2020, 11:21 AM
jhenderson accepted this revision.Apr 9 2020, 12:14 AM

All seems reasonable to me. Thanks!

This revision was automatically updated to reflect the committed changes.