This is an archive of the discontinued LLVM Phabricator instance.

Differential D77713

[Docs] Add description for zerosign and exception option in llc
ClosedPublic

Authored by qiucf on Apr 8 2020, 1:36 AM.

Details

Reviewers
jhenderson
seaneveson
abrachet
mehdi_amini
Commits
rG68460148d545: [Docs] Add more FP option description for llc
Summary

This patch adds missing description of --enable-no-signed-zeros-fp-math and --enable-no-trapping-fp-math options of llc.

Diff Detail

Unit TestsFailed

TimeTest
150 mslldb-unit.Host/_/HostTests::Unknown Unit Message ("")

Event Timeline

qiucf created this revision.Apr 8 2020, 1:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2020, 1:36 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
jhenderson added inline comments.Apr 8 2020, 2:12 AM
llvm/docs/CommandGuide/llc.rst
121

The help text appears to say "setting the FP exceptions build attribute" which is slightly differently worded. I don't know really anything about the area, so I can't say whether that's significant or not?

Harbormaster failed remote builds in B52312: Diff 255924!Apr 8 2020, 3:13 AM
qiucf updated this revision to Diff 256052.Apr 8 2020, 10:00 AM
qiucf marked 2 inline comments as done.

Align with llc help output.

llvm/docs/CommandGuide/llc.rst
121

I think they mean the same. But I should update to align with help output to avoid confusion. Thanks.

Harbormaster failed remote builds in B52378: Diff 256052!Apr 8 2020, 10:51 AM
jhenderson accepted this revision.Apr 9 2020, 12:12 AM

LGTM.

This revision is now accepted and ready to land.Apr 9 2020, 12:12 AM
Closed by commit rG68460148d545: [Docs] Add more FP option description for llc (authored by qiucf). · Explain WhyApr 9 2020, 2:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
docs/
CommandGuide/
8 lines

Diff 256052

llvm/docs/CommandGuide/llc.rst

Show First 20 Lines • Show All 106 Lines • ▼ Show 20 Lines
.. option:: --enable-no-infs-fp-math .. option:: --enable-no-infs-fp-math
Enable optimizations that assume no Inf values. Enable optimizations that assume no Inf values.
.. option:: --enable-no-nans-fp-math .. option:: --enable-no-nans-fp-math
Enable optimizations that assume no NAN values. Enable optimizations that assume no NAN values.
.. option:: --enable-no-signed-zeros-fp-math
Enable FP math optimizations that assume the sign of 0 is insignificant.
.. option:: --enable-no-trapping-fp-math
Enable setting the FP exceptions build attribute not to use exceptions.
jhendersonUnsubmitted
Done
ReplyInline Actions

The help text appears to say "setting the FP exceptions build attribute" which is slightly differently worded. I don't know really anything about the area, so I can't say whether that's significant or not?

jhenderson: The help text appears to say "setting the FP exceptions build attribute" which is slightly…
qiucfAuthorUnsubmitted
Done
ReplyInline Actions

I think they mean the same. But I should update to align with help output to avoid confusion. Thanks.

qiucf: I think they mean the same. But I should update to align with help output to avoid confusion.
.. option:: --enable-unsafe-fp-math .. option:: --enable-unsafe-fp-math
Enable optimizations that make unsafe assumptions about IEEE math (e.g. that Enable optimizations that make unsafe assumptions about IEEE math (e.g. that
addition is associative) or may not work for all input ranges. These addition is associative) or may not work for all input ranges. These
optimizations allow the code generator to make use of some instructions which optimizations allow the code generator to make use of some instructions which
would otherwise not be usable (such as ``fsin`` on X86). would otherwise not be usable (such as ``fsin`` on X86).
.. option:: --stats .. option:: --stats
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines