[SVE] Remove isScalable from Bitcode

[tejohnson]

I'm missing some context. I can't find ScalableVectorType, is this dependent on a pending patch?

[ctetreau]

While immediate feedback would be greatly appreciated, this commit won't actually build until D77587 is merged. I'll ping the thread when this happens if this commit hasn't been accepted yet.

[ctetreau]

In D77695#1970457, @tejohnson wrote:

I'm missing some context. I can't find ScalableVectorType, is this dependent on a pending patch?

I'm working on a big refactor the Type class hierachry, adding a FixedVectorType and ScalableVectorType.

This is part of that. I'm splitting it up as much as possible. As I mentioned above, this won't build until D77587 is merged.

[tejohnson]

In D77695#1970465, @ctetreau wrote:

In D77695#1970457, @tejohnson wrote:

I'm missing some context. I can't find ScalableVectorType, is this dependent on a pending patch?

I'm working on a big refactor the Type class hierachry, adding a FixedVectorType and ScalableVectorType.

This is part of that. I'm splitting it up as much as possible. As I mentioned above, this won't build until D77587 is merged.

Ah ok. For future reference it's typical to add a "Depends on D77587" line to the description to indicate this. This will also automatically add it as the parent version in Phabricator. You can do it now after the fact in Phabricator. See the top right and select "Edit Related Revisions" and add D77587 as the parent.

[ctetreau]

Ah ok. For future reference it's typical to add a "Depends on D77587" line to the description to indicate this. This will also automatically add it as the parent version in Phabricator. You can do it now after the fact in Phabricator. See the top right and select "Edit Related Revisions" and add D77587 as the parent.

Did not know that, thanks for the tip!

[efriedma]

LGTM

llvm/lib/Bitcode/Writer/BitcodeWriter.cpp

for (unsigned i = 0, e = TypeList.size(); i != e; ++i) {
     case Type::FixedVectorTyID:
     case Type::ScalableVectorTyID: {
       VectorType *VT = cast<VectorType>(T);
       // VECTOR [numelts, eltty] or
       //        [numelts, eltty, scalable]
       Code = bitc::TYPE_CODE_VECTOR;
       TypeVals.push_back(VT->getNumElements());
       TypeVals.push_back(VE.getTypeID(VT->getElementType()));
-      if (VT->isScalable())
-        TypeVals.push_back(VT->isScalable());
+      if (isa<ScalableVectorType>(VT))
+        TypeVals.push_back(true);
       break;
     }
     }
 
     // Emit the finished record.
     Stream.EmitRecord(Code, TypeVals, AbbrevToUse);
     TypeVals.clear();
   }