[MLIR][NFC] fix name operand -> op
ClosedPublic
Actions

Authored by bondhugula on Apr 4 2020, 10:11 PM.

Details

Reviewers

Commits

rGcc6738949de8: [MLIR][NFC] fix name operand -> userOp

Summary

The wrong name was confusing to read. value.getUsers() yields
Operation *s.

Depends on D77483.

	Time	Test
	300 ms	Clang Tools.clang-tidy/checkers::Unknown Unit Message ("") Script: -- : 'RUN: at line 1'; /usr/bin/python /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/clang-tools-extra/test/../test/clang-tidy/check_clang_tidy.py /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/clang-tools-extra/test/clang-tidy/checkers/fuchsia-multiple-inheritance.cpp fuchsia-multiple-inheritance /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/build/tools/clang/tools/extra/test/clang-tidy/checkers/Output/fuchsia-multiple-inheritance.cpp.tmp
	230 ms	LLVM.Other::Unknown Unit Message ("") Script: -- : 'RUN: at line 19'; /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/build/bin/opt -O3 -opt-bisect-limit=0 < /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/llvm/test/Other/opt-bisect-legacy-pass-manager.ll \| /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/build/bin/llc -O3 -opt-bisect-limit=0

stephenneuendorffer added inline comments.

mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp
184	This seems like a bad idea to me, since you're shadowing another outer op.

This revision now requires changes to proceed.Apr 4 2020, 10:35 PM

Rename op -> userOp

mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp
184	I hadn't even noticed - thanks! Fixed.

rriddle added inline comments.

mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp
183–184	Can you change this to just `op->getUsers()`? It is cleaner and more efficient.

bondhugula marked 2 inline comments as done.Apr 5 2020, 4:05 AM

bondhugula added inline comments.

mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp
183–184	Yes, but we should do that in another patch - this is meant to be a rename only. There are other instances (two in this file) and about five more in other files that use such a 2-d iteration that could all be replaced.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 5 2020, 6:56 AM

This revision was automatically updated to reflect the committed changes.

bondhugula marked an inline comment as done.