Page MenuHomePhabricator

[MLIR] fix greedy pattern rewrite driver iteration on change

Authored by bondhugula on Apr 4 2020, 8:26 PM.



Removing dead ops should make the outer loop of the pattern rewriting
driver run again. Although its operands are added to the worklist, if no
changes happenned to them or remaining ops in the worklist, the driver
wouldn't run once again - but it should be.

Diff Detail

Unit TestsFailed

230 msClang Tools.clang-tidy/checkers::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; /usr/bin/python /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/clang-tools-extra/test/../test/clang-tidy/ /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/clang-tools-extra/test/clang-tidy/checkers/fuchsia-multiple-inheritance.cpp fuchsia-multiple-inheritance /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/build/tools/clang/tools/extra/test/clang-tidy/checkers/Output/fuchsia-multiple-inheritance.cpp.tmp
420 msLLVM.Other::Unknown Unit Message ("")
Script: -- : 'RUN: at line 19'; /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/build/bin/opt -O3 -opt-bisect-limit=0 < /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/llvm/test/Other/opt-bisect-legacy-pass-manager.ll | /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/build/bin/llc -O3 -opt-bisect-limit=0

Event Timeline

bondhugula created this revision.Apr 4 2020, 8:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2020, 8:26 PM
rriddle accepted this revision.Apr 4 2020, 10:45 PM
This revision is now accepted and ready to land.Apr 4 2020, 10:45 PM
This revision was automatically updated to reflect the committed changes.