Page MenuHomePhabricator

[libc] Add fully-qualified target names.
ClosedPublic

Authored by sivachandra on Apr 2 2020, 3:17 PM.

Details

Summary

Only targets setup by the special LLVM libc rules now have fully
qualified names. The naming style is similar to fully qualified names in
Python.

Diff Detail

Event Timeline

sivachandra created this revision.Apr 2 2020, 3:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 2 2020, 3:17 PM

This change implements the topic I brought up many weeks ago: http://lists.llvm.org/pipermail/libc-dev/2020-January/000038.html.

It is probably motivated by my personal preference largely driven by my experience working with GN and Bazel. I am open to listening to opinions from others as it does add verbosity to the target names and can be viewed as a development overhead. But, it also eliminates ambiguity in naming targets, and makes it clear and explicit what each target is about when one reads the target names. More importantly, I like the fact the we can now set up directory specific build and run targets as I explained in the above post (for example, test.src.signal.__build__ and test.src.signal.__run__.)

abrachet accepted this revision.Apr 3 2020, 3:39 PM

LGTM. I think the shortened name with the . prefix is a little confusing personally, but I can also see how it is useful.

This revision is now accepted and ready to land.Apr 3 2020, 3:39 PM
This revision was automatically updated to reflect the committed changes.