[libc] Fix memcpy to adhere to qualified calls.

[PaulkaToast]

Summary

Switched to using the new memcpy implementation.

[gchatelet]

But wait for @abrachet and @sivachandra

[abrachet]

libc/src/string/strcpy.cpp

19

Should we wait for D77279 to use __llvm_libc::strlen?

[sivachandra]

This patch largely looks good, but I have a question inline.

libc/src/math/round_redirector.cpp

16 ↗

(On Diff #254361)

This comment is not quite the right thing to say. This is a redirector so the expectation is to call round from the system libc.

17 ↗

(On Diff #254361)

Redirected calls should not need NOLINT annotations. Calling into system libc is correct by design. What is failing without this NOLINT annotation?

libc/src/string/strcpy.cpp

19

Yes. Wait for D77279 and absorb the change here.

libc/test/src/string/CMakeLists.txt

14

Can you add a TODO (sivachandra) here and below to remove the redundant deps?

[PaulkaToast]

libc/src/math/round_redirector.cpp

17 ↗

(On Diff #254361)

You're right, redirectors do this by design. Removed comment and nolint.

libc/src/string/strcpy.cpp

19

Gotcha (:

libc/fuzzing/string/CMakeLists.txt

 add_libc_fuzzer(
   strcpy_fuzz
   SRCS
     strcpy_fuzz.cpp
   DEPENDS
     strcpy
     strlen
+    memcpy
 )

libc/src/string/CMakeLists.txt

add_entrypoint_object(
   strcpy
   SRCS
     strcpy.cpp
   HDRS
     strcpy.h
   DEPENDS
     string_h
     strlen
+    memcpy
 )
 
 add_entrypoint_object(
   strlen
   SRCS
     strlen.cpp
   HDRS
     strlen.h

libc/src/string/strcpy.cpp

 //===-------------------- Implementation of strcpy -----------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #include "src/string/strcpy.h"
 #include "src/string/strlen.h"
+#include "src/string/memcpy.h"
 
 #include "src/__support/common.h"
 
 namespace __llvm_libc {
 
 char *LLVM_LIBC_ENTRYPOINT(strcpy)(char *dest, const char *src) {
   return reinterpret_cast<char *>(
-      ::memcpy(dest, src, __llvm_libc::strlen(src) + 1));
+      __llvm_libc::memcpy(dest, src, __llvm_libc::strlen(src) + 1));
 }
 
 } // namespace __llvm_libc

libc/test/src/string/CMakeLists.txt

 add_libc_testsuite(libc_string_unittests)
 
 add_subdirectory(memory_utils)
 
 add_libc_unittest(
   strcat_test
   SUITE
     libc_string_unittests
   SRCS
     strcat_test.cpp
   DEPENDS
     strcat
     strcpy
     strlen
+# TODO (sivachandra): remove redundant deps.
+    memcpy
 )
 
 add_libc_unittest(
   strcpy_test
   SUITE
     libc_string_unittests
   SRCS
     strcpy_test.cpp
   DEPENDS
     strcpy
     strlen
+# TODO (sivachandra): remove redundant deps.
+    memcpy
 )
 
 add_libc_unittest(
   strlen_test
   SUITE
     libc_string_unittests
   SRCS
     strlen_test.cpp