Page MenuHomePhabricator

[Alignment][NFC] Use Align in SelectionDAG::getMemIntrinsicNode
ClosedPublic

Authored by gchatelet on Mar 31 2020, 8:51 AM.

Details

Summary

This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790

Diff Detail

Event Timeline

gchatelet created this revision.Mar 31 2020, 8:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 31 2020, 8:52 AM
tra added a subscriber: tra.Mar 31 2020, 9:44 AM

LGTM for NVPTX changes.

llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp
1616

Perhaps make it explicitly None? It's not obvious that it's the default.

craig.topper added inline comments.
llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
6535

That comma should be on the other side of /* align */ right?

gchatelet updated this revision to Diff 254104.Apr 1 2020, 1:09 AM
gchatelet marked 2 inline comments as done.
  • Address comments and add assert to document that retAlignment is set.
courbet accepted this revision.Apr 1 2020, 1:23 AM
This revision is now accepted and ready to land.Apr 1 2020, 1:23 AM
This revision was automatically updated to reflect the committed changes.