Page MenuHomePhabricator

[MLIR] Add missing asserts in interchangeLoops util, doc comment update
ClosedPublic

Authored by bondhugula on Mar 28 2020, 7:04 PM.

Details

Summary

Add missing assert checks for input to mlir::interchangeLoops utility.
Rename interchangeLoops -> permuteLoops; update doc comments to clarify
inputs / return val. Other than the assert checks, this is NFC.

Signed-off-by: Uday Bondhugula <uday@polymagelabs.com>

Diff Detail

Event Timeline

bondhugula created this revision.Mar 28 2020, 7:04 PM
mehdi_amini added inline comments.Mar 28 2020, 7:40 PM
mlir/lib/Transforms/Utils/LoopUtils.cpp
724

Should we also check that the body of these loops contains only a single operation (other than the terminator)?

bondhugula marked 2 inline comments as done.

perfect nest check

mlir/lib/Transforms/Utils/LoopUtils.cpp
724

Yes, you are right - we should be. Fixed.

mehdi_amini accepted this revision.Mar 29 2020, 11:12 AM
This revision is now accepted and ready to land.Mar 29 2020, 11:12 AM
This revision was automatically updated to reflect the committed changes.