This is an archive of the discontinued LLVM Phabricator instance.

Add /bigobj for SPIRV dialect on MSVC.
ClosedPublic

Authored by stellaraccident on Mar 28 2020, 5:52 PM.

Details

Summary

This object file has grown beyond the default limit, and elsewhere in LLVM, we seem to be setting this flag as a one-off, so continuing that here.

Diff Detail

Event Timeline

mehdi_amini accepted this revision.Mar 28 2020, 6:33 PM

Do why know why is this object so large? This may be an indication of something underlying to look at anyway.

This revision is now accepted and ready to land.Mar 28 2020, 6:33 PM

Do why know why is this object so large? This may be an indication of something underlying to look at anyway.

Afaik, it is not so much "large" as it is quirks about PE object files in debug builds with large string tables. From what I've read, VC emits a lot of sections in that case, and it is the total number of sections that overflows without /bigobj. But to answer your question, no, I did no further analysis. Most projects I work on just uncategorically set /bigobj globally for Windows/VC builds. The only reason not to do so, I am told, is compatibility with tools from prior to about 2005.

This revision was automatically updated to reflect the committed changes.