Page MenuHomePhabricator

[lldb/CMake] Make check-lldb-* work for the standalone build.
ClosedPublic

Authored by JDevlieghere on Mar 27 2020, 12:18 PM.

Details

Summary

In order to run check-lldb-* we need the correct map_config directives in
llvm-lit. Because this is a standalone build, LLVM doesn't know about LLDB,
we need to build our own and tell LLVM to use it.

I tested this for both the standalone Ninja & Xcode standalone build.

Diff Detail

Event Timeline

JDevlieghere created this revision.

Add missing context.

we need to build our own and tell LLVM to use it

To clarify, this means we'd be building our own llvm-lit and using that just for the LLDB test suite, correct?

we need to build our own and tell LLVM to use it

To clarify, this means we'd be building our own llvm-lit and using that just for the LLDB test suite, correct?

Yep, should I reword the comment?

we need to build our own and tell LLVM to use it

To clarify, this means we'd be building our own llvm-lit and using that just for the LLDB test suite, correct?

Yep, should I reword the comment?

I think it's a little confusing as-is. I'm not sure what you meant by "and tell LLVM to use it".

labath accepted this revision.Mar 30 2020, 12:40 AM

sounds reasonable

This revision is now accepted and ready to land.Mar 30 2020, 12:40 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2020, 11:57 AM