Page MenuHomePhabricator

[CMSE] Fix bogus save-temps.c tests
AbandonedPublic

Authored by chill on Mar 24 2020, 5:11 AM.

Details

Summary

080d046c91d2 introduced a couple of test cases to save-temps.c, which
were missing the -### option, so they failed when ARM target was not
configured.

Diff Detail

Event Timeline

chill created this revision.Mar 24 2020, 5:11 AM
dmgreen accepted this revision.Mar 24 2020, 5:16 AM
dmgreen added a subscriber: dmgreen.

SGTM

This revision is now accepted and ready to land.Mar 24 2020, 5:16 AM
chill planned changes to this revision.Mar 24 2020, 6:32 AM
chill updated this revision to Diff 252302.Mar 24 2020, 6:50 AM
chill retitled this revision from [CMSE] Revert bogus save-temps.c tests to [CMSE] Fix bogus save-temps.c tests.
chill edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Mar 24 2020, 6:50 AM
russell.gallop accepted this revision.EditedMar 24 2020, 7:21 AM

LGTM, thanks.

Your fix was slightly different as it has -save-temps on the second RUN %clang. Is this required for the test?

chill added a comment.Mar 24 2020, 9:11 AM

Your fix was slightly different as it has -save-temps on the second RUN %clang. Is this required for the test?

No, it's not necessary, the output is the same, as there are no temps in that case.