This is an archive of the discontinued LLVM Phabricator instance.

Differential D76695

[CMSE] Fix bogus save-temps.c tests
AbandonedPublic

Authored by chill on Mar 24 2020, 5:11 AM.

Details

Reviewers
dmgreen
lebedev.ri
russell.gallop
serge-sans-paille
Summary

080d046c91d2 introduced a couple of test cases to save-temps.c, which
were missing the -### option, so they failed when ARM target was not
configured.

Diff Detail

Event Timeline

chill created this revision.Mar 24 2020, 5:11 AM
dmgreen accepted this revision.Mar 24 2020, 5:16 AM
dmgreen added a subscriber: dmgreen.

SGTM

This revision is now accepted and ready to land.Mar 24 2020, 5:16 AM
chill planned changes to this revision.Mar 24 2020, 6:32 AM
chill updated this revision to Diff 252302.Mar 24 2020, 6:50 AM
chill retitled this revision from [CMSE] Revert bogus save-temps.c tests to [CMSE] Fix bogus save-temps.c tests.
chill edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Mar 24 2020, 6:50 AM
Herald added subscribers: danielkiss, kristof.beyls. · View Herald TranscriptMar 24 2020, 6:50 AM
chill added reviewers: lebedev.ri, russell.gallop, serge-sans-paille.Mar 24 2020, 6:51 AM
russell.gallop accepted this revision.EditedMar 24 2020, 7:21 AM

LGTM, thanks.

chill abandoned this revision.Mar 24 2020, 8:09 AM

FIxed elsewhere https://reviews.llvm.org/rG10bd8422d041e2964c146a38b5514d9d92fc458d

russell.gallop added a comment.Mar 24 2020, 8:41 AM
In D76695#1939266, @chill wrote:

FIxed elsewhere https://reviews.llvm.org/rG10bd8422d041e2964c146a38b5514d9d92fc458d

Your fix was slightly different as it has -save-temps on the second RUN %clang. Is this required for the test?

chill added a comment.Mar 24 2020, 9:11 AM
In D76695#1939345, @russell.gallop wrote:
In D76695#1939266, @chill wrote:

FIxed elsewhere https://reviews.llvm.org/rG10bd8422d041e2964c146a38b5514d9d92fc458d

Your fix was slightly different as it has -save-temps on the second RUN %clang. Is this required for the test?

No, it's not necessary, the output is the same, as there are no temps in that case.

Revision Contents

PathSize
clang/
test/
Driver/
4 lines

Diff 252302

clang/test/Driver/save-temps.c

Show First 20 Lines • Show All 77 Lines • ▼ Show 20 Lines
// CHECK-OBJ-NOO: "-o" "save-temps.o" // CHECK-OBJ-NOO: "-o" "save-temps.o"
// CHECK-OBJ-NOO: "-o" "a.out" // CHECK-OBJ-NOO: "-o" "a.out"
// RUN: %clang -target i386-unknown-freebsd -save-temps -g -c %s -### 2>&1 \ // RUN: %clang -target i386-unknown-freebsd -save-temps -g -c %s -### 2>&1 \
// RUN: | FileCheck %s -check-prefix=CHECK-SAVE-TEMPS // RUN: | FileCheck %s -check-prefix=CHECK-SAVE-TEMPS
// CHECK-SAVE-TEMPS: "-cc1as" // CHECK-SAVE-TEMPS: "-cc1as"
// CHECK-SAVE-TEMPS: "-dwarf-version={{.}}" // CHECK-SAVE-TEMPS: "-dwarf-version={{.}}"
// RUN: %clang --target=arm-arm-none-eabi -march=armv8-m.main -mcmse -save-temps -c -v %s 2>&1 \ // RUN: %clang --target=arm-arm-none-eabi -march=armv8-m.main -mcmse -save-temps -c -v %s -### 2>&1 \
// RUN: | FileCheck %s -check-prefix=CHECK-SAVE-TEMPS-CMSE // RUN: | FileCheck %s -check-prefix=CHECK-SAVE-TEMPS-CMSE
// RUN: %clang --target=arm-arm-none-eabi -march=armv8-m.main -mcmse -x assembler -c -v %s 2>&1 \ // RUN: %clang --target=arm-arm-none-eabi -march=armv8-m.main -mcmse -save-temps -x assembler -c -v %s -### 2>&1 \
// RUN: | FileCheck %s -check-prefix=CHECK-SAVE-TEMPS-CMSE // RUN: | FileCheck %s -check-prefix=CHECK-SAVE-TEMPS-CMSE
// CHECK-SAVE-TEMPS-CMSE: -cc1as // CHECK-SAVE-TEMPS-CMSE: -cc1as
// CHECK-SAVE-TEMPS-CMSE: +8msecext // CHECK-SAVE-TEMPS-CMSE: +8msecext
// CHECK-SAVE-TEMPS-CMSE-NOT: '+cmse' is not a recognized feature for this target (ignoring feature) // CHECK-SAVE-TEMPS-CMSE-NOT: '+cmse' is not a recognized feature for this target (ignoring feature)