Page MenuHomePhabricator

[mlir][Pass] Add support for lowering unary std ops to SPIR-V.
ClosedPublic

Authored by hanchung on Mar 23 2020, 6:13 PM.

Diff Detail

Event Timeline

hanchung created this revision.Mar 23 2020, 6:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2020, 6:13 PM
This revision is now accepted and ready to land.Mar 23 2020, 10:42 PM

Drive by comment: The [Pass] tag generally refers to the general pass manager infrastructure(i.e. the Pass/ directory), so it doesn't really make sense for this revision. Something like [StandardToSPIRV] would have been more appropriate.

antiagainst accepted this revision.Mar 24 2020, 6:12 AM

Drive by comment: The [Pass] tag generally refers to the general pass manager infrastructure(i.e. the Pass/ directory), so it doesn't really make sense for this revision. Something like [StandardToSPIRV] would have been more appropriate.

I'll revise this before landing.

This revision was automatically updated to reflect the committed changes.