This is an archive of the discontinued LLVM Phabricator instance.

[mlir] [VectorOps] A "reference" lowering of vector.transpose to LLVM IR
ClosedPublic

Authored by aartbik on Mar 23 2020, 3:17 PM.

Diff Detail

Event Timeline

aartbik created this revision.Mar 23 2020, 3:17 PM
rriddle added inline comments.Mar 23 2020, 3:24 PM
mlir/include/mlir/Dialect/Vector/VectorOps.td
91

You need mlir after the ticks

aartbik updated this revision to Diff 252161.Mar 23 2020, 3:34 PM

tagged ''' with mlir where applicable

aartbik marked 2 inline comments as done.Mar 23 2020, 3:35 PM
aartbik added inline comments.
mlir/include/mlir/Dialect/Vector/VectorOps.td
91

like so?

Harbormaster completed remote builds in B50172: Diff 252157.
nicolasvasilache accepted this revision.Mar 23 2020, 6:19 PM

LG, thanks Aart!

This revision is now accepted and ready to land.Mar 23 2020, 6:19 PM
This revision was automatically updated to reflect the committed changes.
aartbik marked an inline comment as done.
mehdi_amini added inline comments.Mar 23 2020, 7:32 PM
mlir/lib/Dialect/Vector/VectorTransforms.cpp
867

FYI the comment seems like it wasn't updated

aartbik marked 2 inline comments as done.Mar 23 2020, 8:38 PM
aartbik added inline comments.
mlir/lib/Dialect/Vector/VectorTransforms.cpp
867

Good catch. Will fix.