This is an archive of the discontinued LLVM Phabricator instance.

[libc] Don't configure test and fuzzer when -DLLVM_INCLUDE_TESTS=OFF
ClosedPublic

Authored by abrachet on Mar 22 2020, 3:38 PM.

Download Raw Diff

Details

Reviewers

nathanchance
gchatelet
sivachandra
MaskRay

Commits

rGa1762f9ceb95: [libc] Don't configure test and fuzzer when -DLLVM_INCLUDE_TESTS=OFF

Summary

Fixes problem reported in D74397#1935863

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

abrachet created this revision.Mar 22 2020, 3:38 PM

Herald added subscribers: tschuett, MaskRay, mgorny. · View Herald TranscriptMar 22 2020, 3:38 PM

I can confirm this fixes my issue, thank you for the quick fix! I can approve if need be but might be better for someone else more familiar with this area to do that :)

if(LLVM_INCLUDE_TESTS)
  add_subdirectory(test)
endif()

The pattern can be found elsewhere.

This revision is now accepted and ready to land.Mar 22 2020, 6:09 PM

sivachandra accepted this revision.Mar 22 2020, 9:11 PM

Closed by commit rGa1762f9ceb95: [libc] Don't configure test and fuzzer when -DLLVM_INCLUDE_TESTS=OFF (authored by abrachet). · Explain WhyMar 22 2020, 11:06 PM

This revision was automatically updated to reflect the committed changes.

Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2020, 11:06 PM

Herald added a subscriber: libc-commits. · View Herald Transcript

Thx for the quick fix @abrachet !

Revision Contents

Path

Size

libc/

CMakeLists.txt

6 lines

Diff 251947

libc/CMakeLists.txt

	Show All 26 Lines
	add_subdirectory(config)			add_subdirectory(config)
	add_subdirectory(include)			add_subdirectory(include)
	add_subdirectory(utils)			add_subdirectory(utils)

	# The lib and test directories are added at the very end as tests			# The lib and test directories are added at the very end as tests
	# and libraries potentially draw from the components present in all			# and libraries potentially draw from the components present in all
	# of the other directories.			# of the other directories.
	add_subdirectory(lib)			add_subdirectory(lib)
				if(LLVM_INCLUDE_TESTS)
	add_subdirectory(test)			add_subdirectory(test)
	add_subdirectory(fuzzing)			add_subdirectory(fuzzing)
				endif()