This is an archive of the discontinued LLVM Phabricator instance.

Differential D76541

[clang-tidy][NFC] Add missing check group docs and order entries
ClosedPublic

Authored by whisperity on Mar 21 2020, 3:32 AM.

Details

Reviewers
aaron.ballman
Commits
rGdf5fa4873976: [clang-tidy][NFC] Add missing check group docs and order entries
Summary

Two directories for Tidy checks were missing the appropriate documentation entries, and the module list in the linker file was out of order.

Diff Detail

Event Timeline

whisperity created this revision.Mar 21 2020, 3:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2020, 3:32 AM
Herald added subscribers: cfe-commits, martong, gamesh411 and 5 others. · View Herald Transcript
Harbormaster completed remote builds in B49991: Diff 251832.Mar 21 2020, 4:15 AM
whisperity updated this revision to Diff 251839.Mar 21 2020, 5:23 AM
whisperity retitled this revision from [clang-tidy][docs][NFC] Check group doc line was missing from darwin & linuxkernel to [clang-tidy][NFC] Add missing check group docs and order entries.
whisperity edited the summary of this revision. (Show Details)

ClangTidyForceLinker.h also contained the entries without alphabetic order.

whisperity added a child revision: D76545: [clang-tidy] Add a new check group 'experimental-'.Mar 21 2020, 5:30 AM
Harbormaster completed remote builds in B49994: Diff 251839.Mar 21 2020, 7:29 AM
njames93 added a subscriber: njames93.Mar 21 2020, 10:03 AM

Forgive me if I'm wrong, but these kinds of changes typically don't require a review.

aaron.ballman accepted this revision.Mar 21 2020, 10:42 AM

LGTM!

This revision is now accepted and ready to land.Mar 21 2020, 10:42 AM
aaron.ballman added a comment.Mar 21 2020, 10:42 AM
In D76541#1935163, @njames93 wrote:

Forgive me if I'm wrong, but these kinds of changes typically don't require a review.

NFC changes don't typically require a review, but you're still welcome to ask for a review just the same.

whisperity added a comment.Mar 23 2020, 2:54 AM
In D76541#1935163, @njames93 wrote:

Forgive me if I'm wrong, but these kinds of changes typically don't require a review.

Ah, pardon me. This is the first time I'm touching the insides of Tidy.

Closed by commit rGdf5fa4873976: [clang-tidy][NFC] Add missing check group docs and order entries (authored by whisperity). · Explain WhyMar 23 2020, 3:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang-tools-extra/
docs/
clang-tidy/
4 lines

Diff 251832

clang-tools-extra/docs/clang-tidy/index.rst

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines
====================== ========================================================= ====================== =========================================================
Name prefix Description Name prefix Description
====================== ========================================================= ====================== =========================================================
``abseil-`` Checks related to Abseil library. ``abseil-`` Checks related to Abseil library.
``android-`` Checks related to Android. ``android-`` Checks related to Android.
``boost-`` Checks related to Boost library. ``boost-`` Checks related to Boost library.
``bugprone-`` Checks that target bugprone code constructs. ``bugprone-`` Checks that target bugprone code constructs.
``cert-`` Checks related to CERT Secure Coding Guidelines. ``cert-`` Checks related to CERT Secure Coding Guidelines.
``cppcoreguidelines-`` Checks related to C++ Core Guidelines.
``clang-analyzer-`` Clang Static Analyzer checks. ``clang-analyzer-`` Clang Static Analyzer checks.
``cppcoreguidelines-`` Checks related to C++ Core Guidelines.
``darwin-`` Checks related to Darwin coding conventions.
``fuchsia-`` Checks related to Fuchsia coding conventions. ``fuchsia-`` Checks related to Fuchsia coding conventions.
``google-`` Checks related to Google coding conventions. ``google-`` Checks related to Google coding conventions.
``hicpp-`` Checks related to High Integrity C++ Coding Standard. ``hicpp-`` Checks related to High Integrity C++ Coding Standard.
``linuxkernel-`` Checks related to the Linux Kernel coding conventions.
``llvm-`` Checks related to the LLVM coding conventions. ``llvm-`` Checks related to the LLVM coding conventions.
``llvmlibc-`` Checks related to the LLVM-libc coding standards. ``llvmlibc-`` Checks related to the LLVM-libc coding standards.
``misc-`` Checks that we didn't have a better category for. ``misc-`` Checks that we didn't have a better category for.
``modernize-`` Checks that advocate usage of modern (currently "modern" ``modernize-`` Checks that advocate usage of modern (currently "modern"
means "C++11") language constructs. means "C++11") language constructs.
``mpi-`` Checks related to MPI (Message Passing Interface). ``mpi-`` Checks related to MPI (Message Passing Interface).
``objc-`` Checks related to Objective-C coding conventions. ``objc-`` Checks related to Objective-C coding conventions.
``openmp-`` Checks related to OpenMP API. ``openmp-`` Checks related to OpenMP API.
▲ Show 20 Lines • Show All 264 Lines • Show Last 20 Lines