This is an archive of the discontinued LLVM Phabricator instance.

NFC - Rename VectorOps Dialect to the Vector Dialect
AbandonedPublic

Authored by rsuderman on Mar 16 2020, 3:47 PM.

Details

Summary

Renaming the VectorOps dialect to Vector to better match the names of the other Dialects. This is part of a larger rename to change FooOps dialects as the Ops suffix is redundant.

Diff Detail

Unit TestsFailed

Event Timeline

rsuderman created this revision.Mar 16 2020, 3:47 PM

Although purely mechanical, this is of course a very visible change. Can you state a bit more in the description on where, when, and why the rename was decided?

rsuderman retitled this revision from Rename VectorOps directory to Vector to NFC - Rename VectorOps Dialect to the Vector Dialect.Mar 16 2020, 6:00 PM
rsuderman edited the summary of this revision. (Show Details)

Although purely mechanical, this is of course a very visible change. Can you state a bit more in the description on where, when, and why the rename was decided?

Updated the description. Overall the rename is for consistency and to avoid redundancy. All dialects have Ops so including the "Ops" suffix is unneeded. LoopOps and AffineOps are undergoing similar renames, so updating the VectorOps dialect to match.

rriddle accepted this revision.Mar 16 2020, 6:10 PM
rriddle added inline comments.
mlir/include/mlir/Dialect/Vector/VectorOps.h
14

The second one should still be VectorOps to match the file name.

This revision is now accepted and ready to land.Mar 16 2020, 6:10 PM
aartbik accepted this revision.Mar 16 2020, 6:41 PM

Thanks for the background information and updating the CL description.

rsuderman updated this revision to Diff 250678.Mar 16 2020, 7:54 PM

Corrected VectorOps header.

rsuderman marked an inline comment as done.Mar 16 2020, 7:55 PM

Fixed rriddle@ requests

Synced to head.

rsuderman abandoned this revision.Mar 17 2020, 10:57 AM

Moving to a separate CL to better handle internal integration.

mlir/test/Dialect/Vector/invalid.mlir