[ORC] Enable JITEventListeners in the RTDyldObjectLinkingLayer.
ClosedPublic
Actions

Authored by lhames on Mar 8 2020, 11:08 PM.

Details

Reviewers

Commits

rG98f2bb446107: [ORC] Enable JITEventListeners in the RTDyldObjectLinkingLayer.

Summary

Enable use of ExecutionEngine JITEventListeners in RTDyldObjectLinkingLayer.
This allows existing MCJIT clients to more easily migrate to LLJIT / ORCv2.

Still needs some polish, but posting now so that potential clients can road
test it early.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	680 ms	LLVM.ExecutionEngine/OrcLazy::Unknown Unit Message ("") Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/build/bin/lli -jit-kind=orc-lazy -orc-lazy-debug=funcs-to-stdout /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/llvm/test/ExecutionEngine/OrcLazy/global-ctors-and-dtors.ll \| /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/build/bin/FileCheck /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/llvm/test/ExecutionEngine/OrcLazy/global-ctors-and-dtors.ll
	520 ms	LLVM.ExecutionEngine/OrcLazy::Unknown Unit Message ("") Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/build/bin/lli -jit-kind=orc-lazy -compile-threads=2 -thread-entry hello /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/llvm/test/ExecutionEngine/OrcLazy/multiple-compile-threads-basic.ll \| /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/build/bin/FileCheck /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/llvm/test/ExecutionEngine/OrcLazy/multiple-compile-threads-basic.ll
	640 ms	LLVM.ExecutionEngine/OrcLazy::Unknown Unit Message ("") Script: -- : 'RUN: at line 1'; rm -rf /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/build/test/ExecutionEngine/OrcLazy/Output/static-initializers-in-objectfiles.ll.tmp

Event Timeline

lhames created this revision.Mar 8 2020, 11:08 PM

Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2020, 11:08 PM

Herald added subscribers: ributzka, hiraditya. · View Herald Transcript

Harbormaster failed remote builds in B48516: Diff 249032!Mar 8 2020, 11:57 PM

wenju added a subscriber: wenju.Mar 11 2020, 4:19 PM

wenju added inline comments.Mar 14 2020, 8:29 PM

llvm/lib/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.cpp
87	&MemMgr should be MemMgr.get()

lhames marked an inline comment as done.Mar 15 2020, 3:02 PM

lhames added inline comments.

llvm/lib/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.cpp
87	You're right. Thanks Wenju!

I am going to fix the issue Wenju identified and commit this: further development can happen in-tree.

This revision is now accepted and ready to land.Mar 15 2020, 3:05 PM

This broke tests in exactly the way the precommit test predicted (http://45.33.8.238/linux/12615/step_12.txt). Please fix or revert. (And please look at precommit test results going forward.)

Closed by commit rG98f2bb446107: [ORC] Enable JITEventListeners in the RTDyldObjectLinkingLayer. (authored by lhames). · Explain WhyMar 15 2020, 3:32 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: mgorny. · View Herald TranscriptMar 15 2020, 3:32 PM

In D75838#1923564, @thakis wrote:

This broke tests in exactly the way the precommit test predicted (http://45.33.8.238/linux/12615/step_12.txt). Please fix or revert. (And please look at precommit test results going forward.)

Already reverted. I didn't realize the pre-commit tests were actually reliable: previous Harbormaster messages seemed to just be noise. That's very handy!

Re-enabled in 39253a50f0f with fixes for the use-after-free bug.