Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

wenju (Wenju He)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 24 2019, 12:21 AM (209 w, 3 d)

Recent Activity

Aug 1 2023

wenju added a comment to D155417: [DominanceFrontier] fix addToFrontier to use insert.

MachineDominanceFrontier::addToFrontier.

Where is this used?

Aug 1 2023, 6:33 PM · Restricted Project, Restricted Project

Jul 25 2023

wenju abandoned D156209: [indvars] Fix pointer IV expand type in genLoopLimit.

The regression was an assert failure in IndVarSimplifyPass. The LIT is over-simplified and doesn't have the assert.
I just find out that the regression only exists in non-opaque-pointer mode. So this fix is not needed.
Sorry for the noise. I should have tested the opaque pointer mode.

Jul 25 2023, 3:34 AM · Restricted Project, Restricted Project

Jul 24 2023

wenju updated the diff for D156209: [indvars] Fix pointer IV expand type in genLoopLimit.
Jul 24 2023, 11:44 PM · Restricted Project, Restricted Project
wenju requested review of D156209: [indvars] Fix pointer IV expand type in genLoopLimit.
Jul 24 2023, 11:36 PM · Restricted Project, Restricted Project

Jul 16 2023

wenju requested review of D155417: [DominanceFrontier] fix addToFrontier to use insert.
Jul 16 2023, 10:20 PM · Restricted Project, Restricted Project

Jun 7 2023

wenju added a comment to D148283: [ExecutionEngine] Support TargetExtType in Interpreter.

@jcranmer-intel thank you for the review

Jun 7 2023, 6:19 PM · Restricted Project, Restricted Project

Jun 6 2023

wenju updated the diff for D148283: [ExecutionEngine] Support TargetExtType in Interpreter.

add test of global and poison value, add comment of 'It is safe to treat TargetExtType as its layout type'

Jun 6 2023, 6:38 PM · Restricted Project, Restricted Project
wenju added a comment to D148283: [ExecutionEngine] Support TargetExtType in Interpreter.

I don't have a test case of global variable with target extension type.

Jun 6 2023, 1:28 AM · Restricted Project, Restricted Project
wenju updated the diff for D148283: [ExecutionEngine] Support TargetExtType in Interpreter.

add load/store/constant lit test for changes in ExecutionEngine.cpp

Jun 6 2023, 12:52 AM · Restricted Project, Restricted Project

Jun 5 2023

wenju updated the diff for D152122: Set isRequired true for CFGViewer/CFGPrinter passes.

update llvm/test/Other/cfg-printer-filter.ll to test optnone

Jun 5 2023, 10:26 PM · Restricted Project, Restricted Project

Jun 4 2023

wenju requested review of D152122: Set isRequired true for CFGViewer/CFGPrinter passes.
Jun 4 2023, 10:07 PM · Restricted Project, Restricted Project

Apr 25 2023

wenju added a comment to D148283: [ExecutionEngine] Support TargetExtType in Interpreter.

kindly ping @jcranmer-intel

Apr 25 2023, 12:55 AM · Restricted Project, Restricted Project

Apr 19 2023

wenju requested review of D148774: [ValueMapper] allow mapping ConstantTargetNone to its layout type.
Apr 19 2023, 7:32 PM · Restricted Project, Restricted Project

Apr 13 2023

wenju requested review of D148283: [ExecutionEngine] Support TargetExtType in Interpreter.
Apr 13 2023, 6:19 PM · Restricted Project, Restricted Project

Aug 22 2022

wenju abandoned D124355: [LoopUnroll] allow customization of threshold for new-pm.
Aug 22 2022, 1:31 AM · Restricted Project, Restricted Project

May 5 2022

wenju updated the diff for D124355: [LoopUnroll] allow customization of threshold for new-pm.

rebase

May 5 2022, 7:40 PM · Restricted Project, Restricted Project

Apr 25 2022

wenju added a comment to D124355: [LoopUnroll] allow customization of threshold for new-pm.

Can you just have getUnrollingPreferences override the UP.Threshold for your target?

Thanks for the suggestion.

Or is it that you want a specific run of the unroll pass to have a lower threshold than other runs?

Yes, our pipeline contains several calls of LoopUnroll pass with different thresholds, so I think getUnrollingPreferences or overriding command line option wouldn't work.

Apr 25 2022, 2:34 AM · Restricted Project, Restricted Project
wenju added a comment to D124355: [LoopUnroll] allow customization of threshold for new-pm.

Do you have any plans to add a user of the new Threshold option upstream

Apr 25 2022, 1:38 AM · Restricted Project, Restricted Project

Apr 24 2022

wenju requested review of D124355: [LoopUnroll] allow customization of threshold for new-pm.
Apr 24 2022, 7:58 PM · Restricted Project, Restricted Project

Apr 18 2022

wenju added a comment to D123573: [InferAddressSpaces] Check if AS are the same in isNoopPtrIntCastPair.

@arsenm could you please submit for me? I don't have the permission. Thank you.

Apr 18 2022, 6:38 PM · Restricted Project, Restricted Project

Apr 14 2022

wenju updated the diff for D123573: [InferAddressSpaces] Check if AS are the same in isNoopPtrIntCastPair.

remove OverrideFlatAS, move test into X86 folder

Apr 14 2022, 8:46 PM · Restricted Project, Restricted Project

Apr 12 2022

wenju added inline comments to D123573: [InferAddressSpaces] Check if AS are the same in isNoopPtrIntCastPair.
Apr 12 2022, 9:10 PM · Restricted Project, Restricted Project
wenju abandoned D123368: [X86] Remove different address space check in isNoopAddrSpaceCast.
Apr 12 2022, 12:22 AM · Restricted Project, Restricted Project
wenju added a comment to D123368: [X86] Remove different address space check in isNoopAddrSpaceCast.

So you're claiming InferAddressSpaces asserts for x86? Can you add a test?

Apr 12 2022, 12:21 AM · Restricted Project, Restricted Project
wenju requested review of D123573: [InferAddressSpaces] Check if AS are the same in isNoopPtrIntCastPair.
Apr 12 2022, 12:19 AM · Restricted Project, Restricted Project

Apr 10 2022

wenju added a comment to D123368: [X86] Remove different address space check in isNoopAddrSpaceCast.

isNoopPtrIntCastPair in lib/Transforms/Scalar/InferAddressSpaces.cpp calls isNoopAddrSpaceCast, but the two arguments might be the same. I notice isNoopAddrSpaceCast in other targets don't have such assert, so I remove this assert in X86 target.
Do you think we should check address spaces are not the same prior to isNoopAddrSpaceCast callsite in isNoopPtrIntCastPair?

Apr 10 2022, 5:03 PM · Restricted Project, Restricted Project

Apr 8 2022

wenju requested review of D123368: [X86] Remove different address space check in isNoopAddrSpaceCast.
Apr 8 2022, 1:18 AM · Restricted Project, Restricted Project

Mar 31 2022

wenju added a comment to D122296: [NewPM] Add OptimizerEarly module extension point.

RISCV LIT fails should not be related to this patch. Today I've verified this patch with check-llvm on latest llvm.

Mar 31 2022, 2:05 AM · Restricted Project, Restricted Project

Mar 24 2022

wenju updated the diff for D122296: [NewPM] Add OptimizerEarly module extension point.

fix lit merge conflict

Mar 24 2022, 5:15 PM · Restricted Project, Restricted Project

Mar 23 2022

wenju added inline comments to D122296: [NewPM] Add OptimizerEarly module extension point.
Mar 23 2022, 5:58 PM · Restricted Project, Restricted Project
wenju updated the diff for D122296: [NewPM] Add OptimizerEarly module extension point.

move OptimizerEarlyEPCallbacks after RecomputeGlobalsAAPass

Mar 23 2022, 5:52 PM · Restricted Project, Restricted Project
wenju requested review of D122296: [NewPM] Add OptimizerEarly module extension point.
Mar 23 2022, 1:08 AM · Restricted Project, Restricted Project

Aug 9 2021

wenju abandoned D105461: [Support] CommandLine.cpp - Fix thread race condition in addOption.
Aug 9 2021, 6:13 PM · Restricted Project

Jul 28 2021

wenju added a comment to D105461: [Support] CommandLine.cpp - Fix thread race condition in addOption.

The issue is that DefaultOptions is special and delay-processed in CommandLineParser::ParseCommandLineOptions. Suppose the main thread calls llvm:🆑:ParseCommandLineOptions, then DefaultOptions is processed but it is not cleared after processing.
Multithreads calling setCommandLineOpts in clang/lib/CodeGen/BackendUtil.cpp will have race condition on repeated and redundant processing of DefaultOptions. This race condition (SC->OptionsMap) is also explained in https://reviews.llvm.org/D99652

Jul 28 2021, 6:54 PM · Restricted Project

Jul 7 2021

wenju updated the diff for D105461: [Support] CommandLine.cpp - Fix thread race condition in addOption.
Jul 7 2021, 10:21 PM · Restricted Project

Jul 5 2021

wenju requested review of D105461: [Support] CommandLine.cpp - Fix thread race condition in addOption.
Jul 5 2021, 11:57 PM · Restricted Project

Mar 30 2020

wenju added a reviewer for D77032: [x86] Fix Intel OpenCL builtin CalleeSavedRegs on skx: craig.topper.
Mar 30 2020, 10:22 PM · Restricted Project

Mar 29 2020

wenju created D77032: [x86] Fix Intel OpenCL builtin CalleeSavedRegs on skx.
Mar 29 2020, 9:24 PM · Restricted Project

Mar 14 2020

wenju added inline comments to D75838: [ORC] Enable JITEventListeners in the RTDyldObjectLinkingLayer..
Mar 14 2020, 8:58 PM · Restricted Project

Sep 24 2019

wenju added a comment to D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.

We see error "clang (LLVM option parsing): for the --pgo-warn-misexpect option: may only occur zero or one times!" when clang::CompilerInvocation::CreateFromArgs and clang::ExecuteCompilerInvocation are called twice.

Sep 24 2019, 12:45 AM · Restricted Project, Restricted Project, Restricted Project