This is an archive of the discontinued LLVM Phabricator instance.

[mlir][nfc] Fix building mlir_c_runner_utils for Windows
ClosedPublic

Authored by kernhanda on Mar 6 2020, 12:58 PM.

Details

Summary

On Windows, building mlir_c_runner_utils doesn't properly export
symbols, thus resulting in an implib not being created, which causes
an error when consuming LLVM from external projects.

Authors: Mason Remy <masonremy@gmail.com>

Diff Detail

Event Timeline

kernhanda created this revision.Mar 6 2020, 12:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 6 2020, 12:58 PM

This will need to be committed on my behalf.

nicolasvasilache accepted this revision.Mar 6 2020, 7:52 PM
This revision is now accepted and ready to land.Mar 6 2020, 7:52 PM

Confirming that the authorship is "Mason Remy <masonremy@gmail.com>"?

This revision was automatically updated to reflect the committed changes.

Please look at https://reviews.llvm.org/D76031, it is pretty vanilla but I'd rather have someone test it on Windows.