This is an archive of the discontinued LLVM Phabricator instance.

Differential D75769

[mlir][nfc] Fix building mlir_c_runner_utils for Windows
ClosedPublic

Authored by kernhanda on Mar 6 2020, 12:58 PM.

Details

Reviewers
nicolasvasilache
ftynse
mehdi_amini
Commits
rGc3108404c19a: [mlir][nfc] Fix building mlir_c_runner_utils for Windows
Summary

On Windows, building mlir_c_runner_utils doesn't properly export
symbols, thus resulting in an implib not being created, which causes
an error when consuming LLVM from external projects.

Authors: Mason Remy <masonremy@gmail.com>

Diff Detail

Event Timeline

kernhanda created this revision.Mar 6 2020, 12:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 6 2020, 12:58 PM
Herald added subscribers: llvm-commits, Joonsoo, liufengdb and 9 others. · View Herald Transcript
kernhanda added a comment.Mar 6 2020, 12:59 PM

This will need to be committed on my behalf.

Harbormaster completed remote builds in B48383: Diff 248810.Mar 6 2020, 1:48 PM
nicolasvasilache accepted this revision.Mar 6 2020, 7:52 PM
This revision is now accepted and ready to land.Mar 6 2020, 7:52 PM
rriddle added a comment.Mar 6 2020, 10:45 PM

Confirming that the authorship is "Mason Remy <masonremy@gmail.com>"?

Closed by commit rGc3108404c19a: [mlir][nfc] Fix building mlir_c_runner_utils for Windows (authored by Mason Remy <masonremy@gmail.com>, committed by rriddle). · Explain WhyMar 6 2020, 10:57 PM
This revision was automatically updated to reflect the committed changes.
nicolasvasilache added a comment.Mar 11 2020, 3:55 PM

Please look at https://reviews.llvm.org/D76031, it is pretty vanilla but I'd rather have someone test it on Windows.

Revision Contents

PathSize
mlir/
include/
mlir/
ExecutionEngine/
2 lines
lib/
ExecutionEngine/
2 lines

Diff 248810

mlir/include/mlir/ExecutionEngine/CRunnerUtils.h

Context not available.
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Small runtime support "lib" for vector.print lowering during codegen. // Small runtime support "lib" for vector.print lowering during codegen.
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
extern "C" MLIR_CRUNNERUTILS_EXPORT void print_i32(int32_t i);
extern "C" MLIR_CRUNNERUTILS_EXPORT void print_i64(int64_t l);
extern "C" MLIR_CRUNNERUTILS_EXPORT void print_f32(float f); extern "C" MLIR_CRUNNERUTILS_EXPORT void print_f32(float f);
extern "C" MLIR_CRUNNERUTILS_EXPORT void print_f64(double d); extern "C" MLIR_CRUNNERUTILS_EXPORT void print_f64(double d);
extern "C" MLIR_CRUNNERUTILS_EXPORT void print_open(); extern "C" MLIR_CRUNNERUTILS_EXPORT void print_open();
Context not available.

mlir/lib/ExecutionEngine/CRunnerUtils.cpp

Context not available.
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include "mlir/ExecutionEngine/CRunnerUtils.h"
#include <cinttypes> #include <cinttypes>
#include <cstdio> #include <cstdio>
Context not available.