Page MenuHomePhabricator

[clang-format] do not insert spaces around inline asm symbolic names
ClosedPublic

Authored by krasimir on Mar 5 2020, 4:34 AM.

Details

Summary

Fixes https://bugs.llvm.org/show_bug.cgi?id=45108.

The [ in such cases was mis-annotated as an TT_ArrayInitializerLSquare.

Diff Detail

Event Timeline

krasimir created this revision.Mar 5 2020, 4:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2020, 4:34 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
krasimir edited the summary of this revision. (Show Details)Mar 5 2020, 4:37 AM
krasimir added a reviewer: hans.
hans added a comment.Mar 5 2020, 4:49 AM

Very nice, thanks!

clang/lib/Format/TokenAnnotator.cpp
502

Is the Style.isCpp() check necessary here?

If it's necessary, maybe that's because the setting of InsideInlineASM should be guarded by Style.isCpp() instead?

krasimir updated this revision to Diff 248445.Mar 5 2020, 4:57 AM
krasimir marked an inline comment as done.

Remove redundant check.

krasimir marked an inline comment as done.Mar 5 2020, 4:58 AM
krasimir added inline comments.
clang/lib/Format/TokenAnnotator.cpp
502

Good point! I think it's unnecessary.

hans accepted this revision.Mar 5 2020, 4:59 AM

lgtm, thanks for the quick fix!

This revision is now accepted and ready to land.Mar 5 2020, 4:59 AM
krasimir updated this revision to Diff 248449.Mar 5 2020, 5:16 AM

Merging commits into 1 patch

This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B48182: Diff 248449.
MyDeveloperDay added a project: Restricted Project.Mar 5 2020, 7:15 AM