This is an archive of the discontinued LLVM Phabricator instance.

[AssumeBundles] Move to IR so it can be used by Analysis
ClosedPublic

Authored by Tyker on Mar 4 2020, 8:43 AM.

Details

Summary

I didn't think about it when i placed utilities for assume bundles in Transform/Utils but Analysis need to be able to use it.

may be IR is a better fit since this also contains utilities like BuildAssumeFromInst.

Diff Detail

Event Timeline

Tyker created this revision.Mar 4 2020, 8:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2020, 8:43 AM

I'm not sure if the IR generation is placed well in Analysis. You mentioned IR, maybe that is the proper place. Or we split it in the Analysis and transformation part?

Tyker updated this revision to Diff 248779.Mar 6 2020, 10:03 AM

i decided to move it to IR soo all the fonctionalities stay together.
this is easier for testing since many tests build an llvm.assume
than check what it contains with teh Queries.

Tyker retitled this revision from [AssumeBundles] Move to Analysis so it can be used by Analysis to [AssumeBundles] Move to IR so it can be used by Analysis.Mar 6 2020, 10:05 AM
jdoerfert accepted this revision.Mar 6 2020, 12:20 PM

LGTM. Adjust commit message though

This revision is now accepted and ready to land.Mar 6 2020, 12:20 PM
This revision was automatically updated to reflect the committed changes.
JDevlieghere added a subscriber: JDevlieghere.EditedMar 9 2020, 9:02 AM

This broke the modules build :
http://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/

Given that these bots have been red for more than 24 hours I'm going to go ahead and revert this patch.