I didn't think about it when i placed utilities for assume bundles in Transform/Utils but Analysis need to be able to use it.
may be IR is a better fit since this also contains utilities like BuildAssumeFromInst.
Paths
| Differential D75618
[AssumeBundles] Move to IR so it can be used by Analysis ClosedPublic Authored by Tyker on Mar 4 2020, 8:43 AM.
Details Summary I didn't think about it when i placed utilities for assume bundles in Transform/Utils but Analysis need to be able to use it. may be IR is a better fit since this also contains utilities like BuildAssumeFromInst.
Diff Detail Event TimelineTyker added a parent revision: D75616: [AssumeBundles] Add API to query a bundles from a use.Mar 4 2020, 9:08 AM Comment Actions I'm not sure if the IR generation is placed well in Analysis. You mentioned IR, maybe that is the proper place. Or we split it in the Analysis and transformation part? Comment Actions i decided to move it to IR soo all the fonctionalities stay together. Tyker retitled this revision from [AssumeBundles] Move to Analysis so it can be used by Analysis to [AssumeBundles] Move to IR so it can be used by Analysis.Mar 6 2020, 10:05 AM This revision is now accepted and ready to land.Mar 6 2020, 12:20 PM Closed by commit rG57c964aaa76b: [AssumeBundles] Move to IR so it can be used by Analysis (authored by Tyker). · Explain WhyMar 8 2020, 5:18 AM This revision was automatically updated to reflect the committed changes. Tyker added a child revision: D75269: [AssumeBundles] Enforce constraints on the operand bundle of llvm.assume.Mar 8 2020, 9:23 AM Comment Actions This broke the modules build : Given that these bots have been red for more than 24 hours I'm going to go ahead and revert this patch.
Revision Contents
Diff 248191 llvm/include/llvm/Analysis/KnowledgeRetention.h
llvm/include/llvm/Transforms/Utils/KnowledgeRetention.h
llvm/lib/Analysis/CMakeLists.txt
llvm/lib/Analysis/KnowledgeRetention.cpp
llvm/lib/Passes/PassBuilder.cpp
llvm/lib/Transforms/Utils/CMakeLists.txt
llvm/lib/Transforms/Utils/KnowledgeRetention.cpp
llvm/test/Analysis/KnowledgeRetention/assume-builder.ll
llvm/test/Transforms/Util/assume-builder.ll
llvm/unittests/Analysis/CMakeLists.txt
llvm/unittests/Analysis/KnowledgeRetentionTest.cpp
llvm/unittests/Transforms/Utils/CMakeLists.txt
|