Page MenuHomePhabricator

[clang-format] Do not format C# array subscript operators as attributes
ClosedPublic

Authored by jbcoe on Mar 3 2020, 4:47 AM.

Details

Summary

Fix misidentification of C# array subscript operators.

Diff Detail

Event Timeline

jbcoe created this revision.Mar 3 2020, 4:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2020, 4:47 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
krasimir accepted this revision.Mar 3 2020, 12:41 PM
krasimir added inline comments.
clang/lib/Format/TokenAnnotator.cpp
376

nit: // Chains of [] in ...

clang/unittests/Format/FormatTestCSharp.cpp
635

please add a } at the end of this examples so that the braces are balanced, otherwise the examples read as incomplete.

This revision is now accepted and ready to land.Mar 3 2020, 12:41 PM
This revision was automatically updated to reflect the committed changes.

sorry could you please take another look at the comments I left