This is an archive of the discontinued LLVM Phabricator instance.

Differential D75502

[libc] Add `errno_h` as a dependency to `sigaddset` and `sigemptyset`.
ClosedPublic

Authored by sivachandra on Mar 2 2020, 11:32 PM.

Details

Reviewers
PaulkaToast
abrachet
Commits
rG80aba2b26245: [libc] Add `errno_h` as a dependency to `sigaddset` and `sigemptyset`.
Summary

The bots are catching this missing dependency.

Diff Detail

Unit TestsFailed

TimeTest
1,410 msClang.Driver::Unknown Unit Message ("")

Event Timeline

sivachandra created this revision.Mar 2 2020, 11:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2020, 11:32 PM
Herald added subscribers: libc-commits, tschuett, MaskRay, mgorny. · View Herald Transcript
abrachet accepted this revision.Mar 2 2020, 11:40 PM

Oops thanks.

This revision is now accepted and ready to land.Mar 2 2020, 11:40 PM
PaulkaToast accepted this revision.Mar 2 2020, 11:43 PM
Harbormaster failed remote builds in B47866: Diff 247801!Mar 3 2020, 12:00 AM
Closed by commit rG80aba2b26245: [libc] Add `errno_h` as a dependency to `sigaddset` and `sigemptyset`. (authored by sivachandra). · Explain WhyMar 3 2020, 12:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
libc/
src/
signal/
linux/
2 lines

Diff 247801

libc/src/signal/linux/CMakeLists.txt

Show All 29 Linesadd_entrypoint_object(
sigemptyset sigemptyset
SRCS SRCS
sigemptyset.cpp sigemptyset.cpp
HDRS HDRS
signal.h signal.h
../sigemptyset.h ../sigemptyset.h
DEPENDS DEPENDS
__errno_location __errno_location
errno_h
signal_h signal_h
) )
add_entrypoint_object( add_entrypoint_object(
sigaddset sigaddset
SRCS SRCS
sigaddset.cpp sigaddset.cpp
HDRS HDRS
signal.h signal.h
../sigaddset.h ../sigaddset.h
DEPENDS DEPENDS
__errno_location __errno_location
errno_h
signal_h signal_h
) )