This is an archive of the discontinued LLVM Phabricator instance.

Differential D75017

[Driver][X86] Add helptext for malign-branch*, mbranches-within-32B-boundaries
ClosedPublic

Authored by skan on Feb 23 2020, 5:05 AM.

Details

Reviewers
annita.zhang
LuoYuanke
craig.topper
lebedev.ri
nemanjai
MaskRay
Commits
rG6a3506a208b9: [Driver][X86] Add helptext for malign-branch*, mbranches-within-32B-boundaries

Diff Detail

Event Timeline

skan created this revision.Feb 23 2020, 5:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2020, 5:05 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
annita.zhang added inline comments.Feb 23 2020, 4:57 PM
clang/include/clang/Driver/Options.td
2175

HelpText<"Align selected branches (fused/jcc/jmp) within 32-byte boundary. The branch types and boundary size can be overwritten by other specific options">;

skan marked an inline comment as done.Feb 23 2020, 6:03 PM
skan added inline comments.
clang/include/clang/Driver/Options.td
2175

This helptext seems too long. Could we use HelpText<"Align selected branches (fused, jcc, jmp) within 32-byte boundary">?

skan updated this revision to Diff 246132.Feb 23 2020, 6:26 PM
annita.zhang accepted this revision.Feb 23 2020, 6:44 PM

LGTM

This revision is now accepted and ready to land.Feb 23 2020, 6:44 PM
Closed by commit rG6a3506a208b9: [Driver][X86] Add helptext for malign-branch*, mbranches-within-32B-boundaries (authored by skan). · Explain WhyFeb 23 2020, 9:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
include/
clang/
Driver/
9 lines

Diff 246138

clang/include/clang/Driver/Options.td

Show First 20 Lines • Show All 2,160 Lines • ▼ Show 20 Lines
def mx32 : Flag<["-"], "mx32">, Group<m_Group>, Flags<[DriverOption, CoreOption]>; def mx32 : Flag<["-"], "mx32">, Group<m_Group>, Flags<[DriverOption, CoreOption]>;
def mabi_EQ : Joined<["-"], "mabi=">, Group<m_Group>; def mabi_EQ : Joined<["-"], "mabi=">, Group<m_Group>;
def miamcu : Flag<["-"], "miamcu">, Group<m_Group>, Flags<[DriverOption, CoreOption]>, def miamcu : Flag<["-"], "miamcu">, Group<m_Group>, Flags<[DriverOption, CoreOption]>,
HelpText<"Use Intel MCU ABI">; HelpText<"Use Intel MCU ABI">;
def mno_iamcu : Flag<["-"], "mno-iamcu">, Group<m_Group>, Flags<[DriverOption, CoreOption]>; def mno_iamcu : Flag<["-"], "mno-iamcu">, Group<m_Group>, Flags<[DriverOption, CoreOption]>;
def malign_functions_EQ : Joined<["-"], "malign-functions=">, Group<clang_ignored_m_Group>; def malign_functions_EQ : Joined<["-"], "malign-functions=">, Group<clang_ignored_m_Group>;
def malign_loops_EQ : Joined<["-"], "malign-loops=">, Group<clang_ignored_m_Group>; def malign_loops_EQ : Joined<["-"], "malign-loops=">, Group<clang_ignored_m_Group>;
def malign_jumps_EQ : Joined<["-"], "malign-jumps=">, Group<clang_ignored_m_Group>; def malign_jumps_EQ : Joined<["-"], "malign-jumps=">, Group<clang_ignored_m_Group>;
def malign_branch_EQ : CommaJoined<["-"], "malign-branch=">, Group<m_Group>; def malign_branch_EQ : CommaJoined<["-"], "malign-branch=">, Group<m_Group>, Flags<[DriverOption]>,
def malign_branch_boundary_EQ : Joined<["-"], "malign-branch-boundary=">, Group<m_Group>; HelpText<"Specify types of branches to align">;
def malign_branch_boundary_EQ : Joined<["-"], "malign-branch-boundary=">, Group<m_Group>, Flags<[DriverOption]>,
HelpText<"Specify the boundary's size to align branches">;
def malign_branch_prefix_size_EQ : Joined<["-"], "malign-branch-prefix-size=">, Group<m_Group>; def malign_branch_prefix_size_EQ : Joined<["-"], "malign-branch-prefix-size=">, Group<m_Group>;
def mbranches_within_32B_boundaries : Flag<["-"], "mbranches-within-32B-boundaries">, Flags<[DriverOption]>, Group<m_Group>; def mbranches_within_32B_boundaries : Flag<["-"], "mbranches-within-32B-boundaries">, Flags<[DriverOption]>, Group<m_Group>,
HelpText<"Align selected branches (fused, jcc, jmp) within 32-byte boundary">;
annita.zhangUnsubmitted
Not Done
ReplyInline Actions

HelpText<"Align selected branches (fused/jcc/jmp) within 32-byte boundary. The branch types and boundary size can be overwritten by other specific options">;

annita.zhang: HelpText<"Align selected branches (fused/jcc/jmp) within 32-byte boundary. The branch types and…
skanAuthorUnsubmitted
Done
ReplyInline Actions

This helptext seems too long. Could we use HelpText<"Align selected branches (fused, jcc, jmp) within 32-byte boundary">?

skan: This helptext seems too long. Could we use `HelpText<"Align selected branches (fused, jcc…
def mfancy_math_387 : Flag<["-"], "mfancy-math-387">, Group<clang_ignored_m_Group>; def mfancy_math_387 : Flag<["-"], "mfancy-math-387">, Group<clang_ignored_m_Group>;
def mlong_calls : Flag<["-"], "mlong-calls">, Group<m_Group>, def mlong_calls : Flag<["-"], "mlong-calls">, Group<m_Group>,
HelpText<"Generate branches with extended addressability, usually via indirect jumps.">; HelpText<"Generate branches with extended addressability, usually via indirect jumps.">;
def LongDouble_Group : OptionGroup<"<LongDouble group>">, Group<m_Group>, def LongDouble_Group : OptionGroup<"<LongDouble group>">, Group<m_Group>,
DocName<"Long double flags">, DocName<"Long double flags">,
DocBrief<[{Selects the long double implementation}]>; DocBrief<[{Selects the long double implementation}]>;
def mlong_double_64 : Flag<["-"], "mlong-double-64">, Group<LongDouble_Group>, Flags<[CC1Option]>, def mlong_double_64 : Flag<["-"], "mlong-double-64">, Group<LongDouble_Group>, Flags<[CC1Option]>,
HelpText<"Force long double to be 64 bits">; HelpText<"Force long double to be 64 bits">;
▲ Show 20 Lines • Show All 1,247 Lines • Show Last 20 Lines