Page MenuHomePhabricator

[libc] Add an optional `NAME` argument to `add_entrypoint_object` rule.
ClosedPublic

Authored by sivachandra on Feb 20 2020, 10:13 PM.

Details

Summary

This argument can be used to specify the entrypoint name if it is different
from the target name.

Diff Detail

Event Timeline

sivachandra created this revision.Feb 20 2020, 10:13 PM
abrachet accepted this revision.Feb 20 2020, 10:50 PM
abrachet added a subscriber: abrachet.
abrachet added inline comments.
libc/cmake/modules/LLVMLibCRules.cmake
113

Name is also optional, should it's comment say so?

This revision is now accepted and ready to land.Feb 20 2020, 10:50 PM
sivachandra marked an inline comment as done.Feb 20 2020, 10:58 PM
sivachandra added inline comments.
libc/cmake/modules/LLVMLibCRules.cmake
113

I called them "optional arguments" throughout which is probably a mistake/misnomer. They should actually be called "option arguments" to match the CMake documentation: https://cmake.org/cmake/help/v3.14/command/cmake_parse_arguments.html

Will update separately.

gchatelet accepted this revision.Feb 21 2020, 12:52 AM

LGTM thx!

This revision was automatically updated to reflect the committed changes.