Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
This might be wrong. Do we expect to load/store f/i32 instead of spv.array<1 x f/i32 [4]>?
Comment Actions
Might be worth checking that the serialization/deserialization works as well
mlir/test/Conversion/StandardToSPIRV/std-to-spirv.mlir | ||
---|---|---|
319 | Would be good to check the indices here to make sure it is doing spv.AccessChain %arg0[0] |
Comment Actions
This looks fine to me. Thanks for adding this.
But please add serialization tests as well