Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D74865

[MLIR] add show-dialects option for mlir-opt
ClosedPublic
Actions

Authored by stephenneuendorffer on Feb 19 2020, 1:28 PM.

Details

Reviewers
mehdi_amini
rriddle
Commits
rG01b209679f69: [MLIR] add show-dialects option for mlir-opt
Summary

Display the list of dialects known to mlir-opt. This is useful
for ensuring that linkage has happened correctly, for instance.

Diff Detail

Event Timeline

stephenneuendorffer created this revision.Feb 19 2020, 1:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 19 2020, 1:28 PM
Herald added subscribers: llvm-commits, Joonsoo, liufengdb and 11 others. · View Herald Transcript
stephenneuendorffer added a child revision: D74866: [MLIR] Workaround for broken dependencies with building libMLIR.so.Feb 19 2020, 1:28 PM
Harbormaster completed remote builds in B46848: Diff 245503.Feb 19 2020, 2:18 PM
mehdi_amini accepted this revision.Feb 19 2020, 10:03 PM
This revision is now accepted and ready to land.Feb 19 2020, 10:03 PM
stephenneuendorffer updated this revision to Diff 245742.Feb 20 2020, 2:07 PM
stephenneuendorffer edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B46953: Diff 245742.Feb 20 2020, 2:23 PM
stephenneuendorffer updated this revision to Diff 247027.Feb 27 2020, 10:39 AM
rriddle accepted this revision.Feb 27 2020, 10:41 AM
rriddle added inline comments.
mlir/tools/mlir-opt/mlir-opt.cpp
141

Can you please sink the context into the if you avoid unnecessarily initializing it?

144

nit: Remove the trivial brace here.

Closed by commit rG01b209679f69: [MLIR] add show-dialects option for mlir-opt (authored by stephenneuendorffer). · Explain WhyFeb 27 2020, 10:45 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B47465: Diff 247027.Feb 27 2020, 11:46 AM

Revision Contents
Changeset List

PathSize
mlir/
test/
mlir-opt/
17 lines
tools/
mlir-opt/
16 lines

Diff 247030

View Options

mlir/test/mlir-opt/commandline.mlir

Loading...
View Options

mlir/tools/mlir-opt/mlir-opt.cpp

Loading...