[MLIR] Workaround for broken dependencies with building libMLIR.so

[stephenneuendorffer]

Summary

add_dependencies needs to move to DEPENDS tag

Depends on D74865

mlir/cmake/modules/AddMLIR.cmake

macro(add_mlir_library name)
   else()
     # llvm_add_library ignores BUILD_SHARED_LIBS if STATIC is explicitly set,
     # so we need to handle it here.
     if(BUILD_SHARED_LIBS)
       set(LIBTYPE SHARED)
     else()
       set(LIBTYPE STATIC)
     endif()
-    if(NOT XCODE)
-      # The Xcode generator doesn't handle object libraries correctly.
-      list(APPEND LIBTYPE OBJECT)
-    endif()
+    # if(NOT XCODE)
+    #   # The Xcode generator doesn't handle object libraries correctly.
+    #   list(APPEND LIBTYPE OBJECT)
+    # endif()
     set_property(GLOBAL APPEND PROPERTY MLIR_STATIC_LIBS ${name})
   endif()
   add_llvm_library(${name} ${LIBTYPE} ${ARG_UNPARSED_ARGUMENTS} ${srcs})
 endmacro(add_mlir_library)

mlir/tools/mlir-shlib/CMakeLists.txt

 list(REMOVE_DUPLICATES mlir_libs)
 
 foreach (lib ${mlir_libs})
   if(XCODE)
     # Xcode doesn't support object libraries, so we have to trick it into
     # linking the static libraries instead.
     list(APPEND _DEPS "-force_load" ${lib})
   else()
-    list(APPEND _OBJECTS $<TARGET_OBJECTS:obj.${lib}>)
+    list(APPEND _OBJECTS $<TARGET_OBJECTS:${lib}>)
   endif()
   list(APPEND _DEPS $<TARGET_PROPERTY:${lib},LINK_LIBRARIES>)
 endforeach ()
 
 if(MLIR_LINK_MLIR_DYLIB)
   set(INSTALL_WITH_TOOLCHAIN INSTALL_WITH_TOOLCHAIN)
 endif()