This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Use packed for G_ADD/G_SUB/G_MUL v2s16
ClosedPublic

Authored by arsenm on Feb 17 2020, 7:12 PM.

Details

Diff Detail

Event Timeline

arsenm created this revision.Feb 17 2020, 7:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2020, 7:12 PM
foad added a comment.Feb 18 2020, 10:28 AM

Any tests showing the generated code for add and sub?

Any tests showing the generated code for add and sub?

At some point there needs to be mass port of end to end selection tests, but at this point it's exhausting to test them all and I'm anticipating a lot more merge conflicts as I fix the source modifier matching etc.

foad accepted this revision.Feb 25 2020, 1:27 AM

LGTM.

This revision is now accepted and ready to land.Feb 25 2020, 1:27 AM